fix(correctness): address CNG provider blockers - #10
Merged
Conversation
🎉 All green!🛠️ No new code quality issues 🔗 Commit SHA: fded99b | Docs | Datadog PR Page | Give us feedback! |
thieman
changed the title
thieman
marked this pull request as ready for review
June 23, 2026 18:05
tobz
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShutdownHandlelifecycle footgun and leave cached CNG algorithm providers process-lifetime.dbg!output from library error paths.Fixes #7
Validation
cargo fmt -- --checkcargo check --target x86_64-pc-windows-msvccargo check --target x86_64-pc-windows-msvc --no-default-featurescargo clippy --target x86_64-pc-windows-msvc -- -D warningscargo clippy --target x86_64-pc-windows-msvc --no-default-features -- -D warningsNotes
cargo test,cargo test --doc) were not runnable from this macOS worktree. Test compilation/running that pulls dev dependencies also failed locally because the Windows cross C toolchain/SDK is unavailable (windows.h/Windows target C headers missing foraws-lc-sys), so runtime coverage should be validated by Windows CI/workstation.