Prepare repository for Datadog open source review - #3
Conversation
🎉 All green!🛠️ No new code quality issues 🔗 Commit SHA: 6c413b4 | Docs | Datadog PR Page | Give us feedback! |
tobz
left a comment
tobz
left a comment
There was a problem hiding this comment.
This generally looks right to me, but definitely needs a review from OSPO on the correctness of how we're maintaining the attribution/licensing posture from the original repository.
|
Yup there's an explicit OSPO review step at the end of all this before it actually gets made public |
jszwedko
left a comment
jszwedko
left a comment
There was a problem hiding this comment.
I think we are missing a couple of things:
- A LICENSE file
- deny.toml restricting the license
- CI job that runs
cargo denyto check for incompatible licenses
|
The original LICENSE is still there, though I had a question of whether we're supposed to keep Tom's name in there. My read of MIT is that we should? https://github.com/DataDog/rustls-cng-crypto/blob/main/LICENSE#L1 Will do your next two bullets in the next PR |
|
Aaah, doh, missed that the LICENSE was already in the repo. |
3 participants
Working off of https://datadoghq.atlassian.net/wiki/spaces/OS/pages/2178220485/Releasing+Open+Source+Code+at+Datadog
Summary
LICENSE-3rdparty.csvgenerated bydd-rust-license-tool, trackCargo.lock, and addmake sync-licenses/make check-licenses.dd-octo-stspolicy.DataDog/rustls-cng-crypto.Verification
make check-licensespassed.cargo fmt -- --checkpassed.cargo testwas attempted locally on macOS but failed before testing this crate inwindows-futurewith missingwindows_core::imp::IMarshal/marshalersymbols.cargo check --all-targets --target x86_64-pc-windows-msvcwas attempted locally on macOS but failed because the host lacks Windows SDK headers required byaws-lc-sys(windows.h).Full compile/test validation should run in GitHub Actions on
windows-latest.External follow-ups
dd-octo-stspolicy is enabled before relying on automated signed write-back commits.#opensourcefor review and approval before making the repository public.