Commit 375889d
committed
chore(config): migrate OttlTransformConfiguration to typed config (#1997)
Cut the OTTL transform processor over from the raw
`GenericConfiguration` map to the typed
`SalukiConfiguration` model, following the pattern already applied to
the sibling OTTL filter
processor.
- `OttlTransformConfiguration::from_configuration` now takes the
resolved
`domains::traces::OttlTransform` settings and copies them directly,
instead of deserializing an
`OttlTransformConfig` out of `GenericConfiguration`. The component-local
config module (its
`ErrorMode` enum and `OttlTransformConfig` struct) is removed; the
component reuses the model's
shared `OttlErrorMode`.
- The call site in `run.rs` reads
`saluki.domains.traces.ottl_transform`. Since this was the last
consumer of the raw config in
`add_baseline_traces_pipeline_to_blueprint`, the now-unused
`GenericConfiguration` parameter is dropped from that function.
- The seed source `OttlTransformConfig` in `saluki_only.rs` is aligned
with the filter's: its
`error_mode` deserializes directly into `OttlErrorMode` (rather than a
loose `Option<String>` fed
through a hand-rolled parse helper) and it now rejects unknown fields,
restoring the strict
deserialization the original component had.
`ottl_transform_config` is absent from the vendored Datadog schema, so
it is a Saluki-only key on
the seed track; there is no witnessed alias for it.
- [x] Non-functional (chore, refactoring, docs)
- Rewrote the component tests to build from typed traces settings; all
OTTL transform tests pass.
- Added an `ottl_transform_config` round-trip rejection test mirroring
the filter's.
- `make build-schema-overlay` leaves the tree unchanged; `make fmt`,
`make check-all`, `make test`,
and `make check-docs` all pass.
- Progresses #1788
- Merges into #19871 parent bb0f05f commit 375889d
4 files changed
Lines changed: 160 additions & 309 deletions
File tree
- bin/agent-data-plane/src
- cli
- components/ottl_transform_processor
- lib/agent-data-plane-config-system/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
443 | 443 | | |
444 | 444 | | |
445 | 445 | | |
446 | | - | |
| 446 | + | |
447 | 447 | | |
448 | 448 | | |
449 | 449 | | |
| |||
669 | 669 | | |
670 | 670 | | |
671 | 671 | | |
672 | | - | |
673 | | - | |
| 672 | + | |
674 | 673 | | |
675 | 674 | | |
676 | 675 | | |
| |||
686 | 685 | | |
687 | 686 | | |
688 | 687 | | |
689 | | - | |
| 688 | + | |
690 | 689 | | |
691 | 690 | | |
692 | 691 | | |
| |||
Lines changed: 0 additions & 52 deletions
This file was deleted.
0 commit comments