chore(repo): align test naming and proptest authoring style

Apply the naming and proptest conventions from testing-patterns.md: rename the lone
mod test (singular) in topology/graph.rs to mod tests; fix the dispoint->disjoint
typo in a saluki-context proptest name; rename the saluki-tls partial_load_succeeds
integration test fn to match its file stem; and convert the synchronous apm_stats
property test from the #[test_strategy::proptest] attribute macro to the classic
proptest! block macro (keeping request_builder's genuinely-async proptest on the
attribute macro). The property_test_ CI routing is preserved.

Convert test_-prefixed function names to bare descriptive names in the mixed-style
modules the doc calls out (47 functions across 8 files), leaving internally
consistent files for incremental conversion and deferring translator.rs /
dogstatsd_prefix_filter to G13/G14 which rebuild those tests.

Resolves G11 (KI-14, KI-15, KI-16) of the test suite cleanup plan.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: tobz

lib/saluki-components/src/transforms/apm_stats/aggregation.rs

@@ -515,7 +515,7 @@ mod tests {
     use crate::transforms::apm_stats::statsraw::new_aggregation_from_span;
 
     #[test]
-    fn test_get_status_code() {
+    fn get_status_code_from_attributes() {
         // Empty attrs
         let attrs: FastHashMap<MetaString, AV> = FastHashMap::default();
         assert_eq!(get_status_code(&attrs), 0);
@@ -545,7 +545,7 @@ mod tests {
     }
 
     #[test]
-    fn test_get_grpc_status_code() {
+    fn get_grpc_status_code_from_attributes() {
         // Empty attrs
         let attrs: FastHashMap<MetaString, AV> = FastHashMap::default();
         assert_eq!(get_grpc_status_code(&attrs), GrpcStatusCode::Unset);
@@ -618,7 +618,7 @@ mod tests {
     }
 
     #[test]
-    fn test_new_aggregation() {
+    fn new_aggregation() {
         // Helper to create a span with given service, meta, and metrics
         let make_span = |service: &str,
                          meta: FastHashMap<MetaString, MetaString>,
@@ -736,7 +736,7 @@ mod tests {
     }
 
     #[test]
-    fn test_peer_tags_to_aggregate_for_span() {
+    fn peer_tags_to_aggregate_for_span() {
         // Tests that peer tags are only returned for client/producer/consumer span kinds
         let peer_tags = vec![MetaString::from("server.address"), MetaString::from("_dd.base_service")];
 
@@ -782,7 +782,7 @@ mod tests {
     }
 
     #[test]
-    fn test_is_root_span() {
+    fn is_root_span() {
         let concentrator = SpanConcentrator::new(true, true, &[], 0);
 
         // Span with parent_id = 0 -> is_trace_root = true

lib/saluki-components/src/transforms/apm_stats/mod.rs

@@ -1484,30 +1484,28 @@ mod tests {
         );
     }
 
-    #[test_strategy::proptest]
-    #[cfg_attr(miri, ignore)]
-    fn property_test_split_respects_max_entries(
-        #[strategy(arb_split_inputs())] inputs: (Vec<ClientStatsPayload>, usize),
-    ) {
-        let (payloads, max_entries_per_event) = inputs;
-
-        let input_total: usize = payloads.iter().flat_map(|p| p.stats()).map(|b| b.stats().len()).sum();
-
-        let result = split_into_trace_stats(payloads, max_entries_per_event);
+    proptest! {
+        #[test]
+        #[cfg_attr(miri, ignore)]
+        fn property_test_split_respects_max_entries((payloads, max_entries_per_event) in arb_split_inputs()) {
+            let input_total: usize = payloads.iter().flat_map(|p| p.stats()).map(|b| b.stats().len()).sum();
+
+            let result = split_into_trace_stats(payloads, max_entries_per_event);
+
+            // Property 1: No TraceStats should exceed max_entries_per_event
+            for trace_stats in &result {
+                let count = count_grouped_stats(trace_stats);
+                prop_assert!(
+                    count <= max_entries_per_event,
+                    "TraceStats has {} grouped stats, exceeds max of {}",
+                    count,
+                    max_entries_per_event
+                );
+            }
 
-        // Property 1: No TraceStats should exceed max_entries_per_event
-        for trace_stats in &result {
-            let count = count_grouped_stats(trace_stats);
-            prop_assert!(
-                count <= max_entries_per_event,
-                "TraceStats has {} grouped stats, exceeds max of {}",
-                count,
-                max_entries_per_event
-            );
+            // Property 2: Total stats should be preserved
+            let output_total: usize = result.iter().map(count_grouped_stats).sum();
+            prop_assert_eq!(input_total, output_total, "Total stats count should be preserved");
         }
-
-        // Property 2: Total stats should be preserved
-        let output_total: usize = result.iter().map(count_grouped_stats).sum();
-        prop_assert_eq!(input_total, output_total, "Total stats count should be preserved");
     }
 }

lib/saluki-components/src/transforms/metric_router/mod.rs

@@ -184,7 +184,7 @@ mod tests {
     use super::*;
 
     #[test]
-    fn test_exact_metric_name_matching() {
+    fn exact_metric_name_matching() {
         let router = MetricRouter::new(MetricRouterConfiguration {
             metric_names: vec!["test.counter".to_string(), "another.metric".to_string()],
         })
@@ -208,7 +208,7 @@ mod tests {
     }
 
     #[test]
-    fn test_empty_metric_names_list() {
+    fn empty_metric_names_list() {
         let router = MetricRouter::new(MetricRouterConfiguration { metric_names: vec![] })
             .expect("Should create router successfully");
 

lib/saluki-components/src/transforms/trace_obfuscation/sql.rs

@@ -150,7 +150,7 @@ mod tests {
     }
 
     #[test]
-    fn test_sql_quantizer() {
+    fn sql_quantizer() {
         let cases = vec![
             // Basic cases
             (
@@ -382,7 +382,7 @@ mod tests {
     }
 
     #[test]
-    fn test_keep_sql_alias() {
+    fn keep_sql_alias() {
         let query = "SELECT username AS person FROM users WHERE id=4";
 
         // Test with keep_sql_alias = false (default)
@@ -403,7 +403,7 @@ mod tests {
     }
 
     #[test]
-    fn test_can_obfuscate_autovacuum() {
+    fn can_obfuscate_autovacuum() {
         let config = default_config();
         let cases = vec![
             (
@@ -427,7 +427,7 @@ mod tests {
     }
 
     #[test]
-    fn test_dollar_quoted_func() {
+    fn dollar_quoted_func() {
         let query = "SELECT $func$INSERT INTO table VALUES ('a', 1, 2)$func$ FROM users";
 
         // Test with dollar_quoted_func = false (default)
@@ -451,7 +451,7 @@ mod tests {
     }
 
     #[test]
-    fn test_sql_replace_digits() {
+    fn sql_replace_digits() {
         let config = SqlObfuscationConfig {
             replace_digits: true,
             ..default_config()
@@ -480,7 +480,7 @@ mod tests {
 
     #[test]
     #[ignore] // TODO: $action is obfuscated to ? - tokenizer needs to recognize $identifier as SQL Server variable
-    fn test_single_dollar_identifier() {
+    fn single_dollar_identifier() {
         let query = r#"
 	MERGE INTO Employees AS target
 	USING EmployeeUpdates AS source
@@ -509,7 +509,7 @@ mod tests {
     }
 
     #[test]
-    fn test_pg_json_operators() {
+    fn pg_json_operators() {
         let config = SqlObfuscationConfig {
             dbms: "postgres".to_string(),
             ..default_config()
@@ -553,7 +553,7 @@ mod tests {
     }
 
     #[test]
-    fn test_multiple_process() {
+    fn multiple_process() {
         let config = default_config();
 
         let cases = vec![

lib/saluki-components/src/transforms/trace_sampler/mod.rs

@@ -606,7 +606,7 @@ mod tests {
     }
 
     #[test]
-    fn test_user_priority_detection() {
+    fn user_priority_detection() {
         let sampler = create_test_sampler();
 
         // Test trace with user-set priority = 2 (UserKeep)
@@ -636,7 +636,7 @@ mod tests {
     }
 
     #[test]
-    fn test_trace_level_priority_takes_precedence() {
+    fn trace_level_priority_takes_precedence() {
         let sampler = create_test_sampler();
 
         // Test trace-level priority overrides span priorities (last-seen priority)
@@ -671,7 +671,7 @@ mod tests {
     }
 
     #[test]
-    fn test_manual_keep_with_trace_level_priority() {
+    fn manual_keep_with_trace_level_priority() {
         let mut sampler = create_test_sampler();
         sampler.probabilistic_sampler_enabled = false; // Use legacy path that checks user priority
 
@@ -706,7 +706,7 @@ mod tests {
     }
 
     #[test]
-    fn test_probabilistic_sampling_known_decisions() {
+    fn probabilistic_sampling_known_decisions() {
         // The bucketed probabilistic sampler is fully deterministic: it hashes the trace ID into one of 0x4000
         // buckets and keeps the trace when `bucket < (rate * 0x4000)`. These cases pin the exact keep/drop decision
         // for known trace IDs at known rates, so a regression in the hash, the bucket mask, or the comparison is
@@ -783,7 +783,7 @@ mod tests {
     }
 
     #[test]
-    fn test_probabilistic_sampling_is_deterministic() {
+    fn probabilistic_sampling_is_deterministic() {
         // Determinism is a documented property of `ProbabilisticSampler::sample` (same trace ID + rate always yields
         // the same decision). This is intentionally a determinism-only check; correctness is covered by
         // `test_probabilistic_sampling_known_decisions`.
@@ -796,7 +796,7 @@ mod tests {
     }
 
     #[test]
-    fn test_error_detection() {
+    fn error_detection() {
         let sampler = create_test_sampler();
 
         // Test trace with error field set
@@ -811,7 +811,7 @@ mod tests {
     }
 
     #[test]
-    fn test_sampling_priority_order() {
+    fn sampling_priority_order() {
         // Test modern path: error sampler overrides probabilistic drop
         let mut sampler = create_test_sampler();
         sampler.sampling_rate = 0.5; // 50% sampling rate
@@ -844,7 +844,7 @@ mod tests {
     }
 
     #[test]
-    fn test_empty_trace_handling() {
+    fn empty_trace_handling() {
         let mut sampler = create_test_sampler();
         let mut trace = create_test_trace(vec![]);
 
@@ -854,7 +854,7 @@ mod tests {
     }
 
     #[test]
-    fn test_root_span_detection() {
+    fn root_span_detection() {
         let sampler = create_test_sampler();
 
         // Test 1: Root span with parent_id = 0 (common case)
@@ -911,7 +911,7 @@ mod tests {
     }
 
     #[test]
-    fn test_single_span_sampling() {
+    fn single_span_sampling() {
         let mut sampler = create_test_sampler();
 
         // Test 1: Trace with SSS tags should be kept even when probabilistic would drop it
@@ -949,7 +949,7 @@ mod tests {
     }
 
     #[test]
-    fn test_analytics_events() {
+    fn analytics_events() {
         let sampler = create_test_sampler();
 
         // Test 1: Trace with analyzed spans
@@ -992,7 +992,7 @@ mod tests {
     }
 
     #[test]
-    fn test_probabilistic_sampling_with_prob_rate_key() {
+    fn probabilistic_sampling_with_prob_rate_key() {
         let mut sampler = create_test_sampler();
         sampler.sampling_rate = 0.75; // 75% sampling rate
         sampler.probabilistic_sampler_enabled = true;

lib/saluki-config/src/lib.rs

@@ -930,7 +930,7 @@ mod tests {
     use super::*;
 
     #[tokio::test]
-    async fn test_static_configuration() {
+    async fn static_configuration() {
         let (cfg, _) = ConfigurationLoader::for_tests(
             Some(serde_json::json!({
                 "foo": "bar",
@@ -954,7 +954,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_dynamic_configuration() {
+    async fn dynamic_configuration() {
         let (cfg, sender) = ConfigurationLoader::for_tests(
             Some(serde_json::json!({
                 "foo": "bar",
@@ -1098,7 +1098,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_environment_precedence_over_dynamic() {
+    async fn environment_precedence_over_dynamic() {
         let (cfg, sender) = ConfigurationLoader::for_tests(
             Some(serde_json::json!({
                 "foo": "bar",
@@ -1168,7 +1168,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_dynamic_configuration_add_new_nested_key() {
+    async fn dynamic_configuration_add_new_nested_key() {
         let (cfg, sender) = ConfigurationLoader::for_tests(
             Some(serde_json::json!({
                 "foo": "bar",
@@ -1214,7 +1214,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_underscore_fallback_on_get() {
+    async fn underscore_fallback_on_get() {
         let (cfg, _) = ConfigurationLoader::for_tests(
             Some(serde_json::json!({})),
             Some(&[("RANDOM_KEY".to_string(), "from_env_only".to_string())]),
@@ -1227,7 +1227,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_underscore_fallback_on_get_multi_segment_key() {
+    async fn underscore_fallback_on_get_multi_segment_key() {
         // A single-underscore Agent-style env var (e.g. `DD_DATA_PLANE_API_LISTEN_ADDRESS`, which
         // `for_tests` simulates with the `TEST_` prefix) produces a flat figment key. A deeply
         // nested `get`/`try_get_typed` query must still resolve it via the dot-to-underscore
@@ -1250,7 +1250,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_static_configuration_ready_and_subscribe() {
+    async fn static_configuration_ready_and_subscribe() {
         let (cfg, maybe_sender) = ConfigurationLoader::for_tests(Some(serde_json::json!({})), None, false).await;
         assert!(maybe_sender.is_none());
 
@@ -1262,7 +1262,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_dynamic_configuration_ready_requires_initial_snapshot() {
+    async fn dynamic_configuration_ready_requires_initial_snapshot() {
         // Enable dynamic but do not send the initial snapshot.
         let (cfg, maybe_sender) = ConfigurationLoader::for_tests(Some(serde_json::json!({})), None, true).await;
         assert!(maybe_sender.is_some());
@@ -1273,7 +1273,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_flattened_keys_flat_and_nested() {
+    async fn flattened_keys_flat_and_nested() {
         let (cfg, _) = ConfigurationLoader::for_tests(
             Some(serde_json::json!({
                 "top": "value",
@@ -1297,7 +1297,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_flattened_keys_arrays_are_leaves() {
+    async fn flattened_keys_arrays_are_leaves() {
         let (cfg, _) = ConfigurationLoader::for_tests(
             Some(serde_json::json!({
                 "tags": ["a", "b"],
@@ -1318,7 +1318,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_flattened_keys_null_values_absent() {
+    async fn flattened_keys_null_values_absent() {
         let (cfg, _) = ConfigurationLoader::for_tests(
             Some(serde_json::json!({
                 "present": "yes",