chore: code quality recommendations

Author: jeastham1993

user-management/src/Stickerlandia.UserManagement.AspNet/Program.cs

@@ -36,7 +36,7 @@
     case "AWS":
         break;
     default:
-        throw new Exception($"Unknown driven adapters {drivenAdapters}");
+        throw new ArgumentException($"Unknown driven adapters {drivenAdapters}");
 }
 
 builder.Services

user-management/src/Stickerlandia.UserManagement.Aspire/AppBuilderExtensions.cs

@@ -41,11 +41,11 @@ public static IDistributedApplicationBuilder CreateKafkaTopicsOnReady(
     {
         builder.Eventing.Subscribe<ResourceReadyEvent>(kafka.Resource, async (@event, ct) =>
         {
-            var cs = await kafka.Resource.ConnectionStringExpression.GetValueAsync(ct);
+            var kafkaConnectionString = await kafka.Resource.ConnectionStringExpression.GetValueAsync(ct);
 
             var config = new AdminClientConfig
             {
-                BootstrapServers = cs
+                BootstrapServers = kafkaConnectionString
             };
 
             using var adminClient = new AdminClientBuilder(config).Build();

user-management/src/Stickerlandia.UserManagement.Aspire/DrivenAdapters.cs

@@ -38,7 +38,7 @@ public static DrivenAdapters? DrivenAdapter
                     _drivenAdapter = Aspire.DrivenAdapters.AGNOSTIC;
                     break;
                 default:
-                    throw new Exception($"Unknown host type: '{drivenAdapterSetting}'");
+                    throw new ArgumentException($"Unknown host type: '{drivenAdapterSetting}'");
             }
 
             return _drivenAdapter;

user-management/src/Stickerlandia.UserManagement.FunctionApp/Program.cs

@@ -29,7 +29,7 @@
     case "AWS":
         break;
     default:
-        throw new Exception($"Unknown driven adapters {drivenAdapters}");
+        throw new ArgumentException($"Unknown driven adapters {drivenAdapters}");
 }