feat: azure deployment v1#189
Conversation
There was a problem hiding this comment.
Looks like this is the first inclusion of ADRs in the code base. Wondering if it's intentional to keep them in the PR and add to code base. If so, maybe a way to make them less verbose? Also wondering if the pricing info in here is accurate, see line 86 ~$400-800/month vs ~$150-300 seems like that would be pricing in a lot of data transfer right. Wondering if Claude made those figures up. Ignore this comment if these are temporary as I know it's still a working branch.
|
|
||
| variable "database_connection_string" { | ||
| description = "The connection string to the database used by the application." | ||
| variable "env" { |
There was a problem hiding this comment.
Assuming lack of default value is intentional?
| - Azure CLI installed and authenticated (`az login`) | ||
| - Terraform >= 1.0 | ||
| - Shared infrastructure deployed (see `shared/infra/azure/`) | ||
| - Docker with buildx support (for local builds) |
There was a problem hiding this comment.
Nitpik, I don't need Docker unless I am doing local builds right? Not sure this is 100% clear as written. Maybe we move this requirement under the Deploying with Local Container Builds heading. Also maybe somewhere before the two sets of instructions explicitly preface - you have two options for container images - 1.) build locally 2.) use our images from GHCR then move in to the instructions you have here which are good.
| - Shared infrastructure deployed (see `shared/infra/azure/`) | ||
| - Docker with buildx support (for local builds) | ||
|
|
||
| ## Standard Deployment (from GHCR) |
There was a problem hiding this comment.
Perhaps we add an opinionated recommended annotation here - I think this is the happy path unless they are planning to fork and change the service code.
There was a problem hiding this comment.
Is there a reason for the ephemeral preface here?
There was a problem hiding this comment.
Same comment here, assuming this is a working doc? Not intended to be long-term documentation.
|
Deployed this smoothly and the architecture makes sense to me (with my limited Azure expertise). Only one point of friction:
|
2 participants
No description provided.