Skip to content

Commit 5b38875

Browse files
committed
test(ffe): enable Node.js agentless flag evaluation
1 parent a343b6b commit 5b38875

3 files changed

Lines changed: 8 additions & 4 deletions

File tree

manifests/nodejs.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1710,7 +1710,7 @@ manifest:
17101710
- declaration: missing_feature (Not implemented yet)
17111711
component_version: <5.66.0
17121712
tests/docker_ssi/test_docker_ssi_appsec.py::TestDockerSSIAppsecFeatures::test_telemetry_source_ssi: *ref_5_83_0
1713-
tests/ffe/test_agentless_configuration.py: missing_feature (FFL-2697 tracks Node.js agentless configuration-source implementation; FFL-2731 tracks the system-tests contract)
1713+
tests/ffe/test_agentless_configuration.py: *ref_6_5_0
17141714
tests/ffe/test_dynamic_evaluation.py:
17151715
- weblog_declaration:
17161716
"*": incomplete_test_app
@@ -2073,7 +2073,11 @@ manifest:
20732073
tests/parametric/test_extract_behavior.py::Test_ExtractBehavior_Restart::test_baggage: incomplete_test_app (The parametric test app does not preserve baggage after extraction)
20742074
tests/parametric/test_extract_behavior.py::Test_ExtractBehavior_Restart_With_Extract_First: *ref_5_47_0
20752075
tests/parametric/test_extract_behavior.py::Test_ExtractBehavior_Restart_With_Extract_First::test_baggage: incomplete_test_app (The parametric test app does not preserve baggage after extraction)
2076-
tests/parametric/test_ffe/test_configuration_sources.py: missing_feature (FFL-2697 tracks Node.js agentless configuration-source implementation; FFL-2731 tracks system-tests configuration-source contract)
2076+
tests/parametric/test_ffe/test_configuration_sources.py: *ref_6_5_0
2077+
? tests/parametric/test_ffe/test_configuration_sources.py::Test_Feature_Flag_Configuration_Source_Selection::test_invalid_configuration_source_fails_closed
2078+
: missing_feature (dd-trace-js#9482)
2079+
? tests/parametric/test_ffe/test_configuration_sources.py::Test_Feature_Flag_Configuration_Source_Selection::test_reserved_offline_configuration_source_fails_closed
2080+
: missing_feature (dd-trace-js#9482)
20772081
tests/parametric/test_ffe/test_dynamic_evaluation.py::Test_Feature_Flag_Dynamic_Evaluation: *ref_5_75_0
20782082
tests/parametric/test_ffe/test_span_enrichment.py: "missing_feature (dd-trace-js#8343)"
20792083
tests/parametric/test_headers_b3.py::Test_Headers_B3::test_headers_b3_migrated_extract_invalid: missing_feature (Need to remove b3=b3multi alias)

tests/parametric/capabilities.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ capabilities:
7272
- ASM_ACTIVATION
7373
- ASM_AUTO_USER_INSTRUM_MODE
7474

75-
'>=5.72.0':
75+
'>=5.72.0 <5.116.0 || >=6.0.0-pre <6.5.0':
7676
- FFE_FLAG_CONFIGURATION_RULES
7777

7878
'>=5.83.0':

utils/build/docker/nodejs/parametric/server.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -517,8 +517,8 @@ app.post('/ffe/start', async (req, res) => {
517517
].some(name => process.env[name] !== undefined)
518518

519519
if (hasFeatureFlaggingConfiguration) {
520-
const { openfeature } = tracer
521520
try {
521+
const { openfeature } = tracer
522522
await OpenFeature.setProviderAndWait(openfeature)
523523
} catch {
524524
openFeatureClient = OpenFeature.getClient()

0 commit comments

Comments
 (0)