Apply suggestions from code review

Co-authored-by: Célian Raimbault <161456554+CelianR@users.noreply.github.com>

Author: KevinFairise2

README.md

@@ -63,9 +63,6 @@ Run any `-h` on any of the available tasks for more information
 ## MacOS support
 
 The `aws.create-vm` task should allow you to spin up a MacOS instance using `-o macos` flag. Note that spinning such an instance is expensive because it requires a dedicated host. When you have one running please reuse it instead of creating new instances every time you need it. The cleaner will automatically get rid of the dedicated hosts.
-
-
-
 ## Troubleshooting
 
 ### Environment and configuration

components/datadog/agent/host_macos.go

@@ -22,7 +22,7 @@ func newMacOSManager(host *remoteComp.Host) agentOSManager {
 
 // directInstallCommand expects a locally provided .dmg or .pkg uploaded to the host; it will install it with installer
 func (am *agentMacOSManager) directInstallCommand(env config.Env, packagePath string, _ agentparams.PackageVersion, additionalInstallParameters []string, opts ...pulumi.ResourceOption) (command.Command, error) {
-	// Unsupported for now, installing directly from a dmg without the install script requires way too many step that would imply duplicating the install script code in there.
+	// Unsupported for now.
 	return nil, fmt.Errorf("installing directly from a dmg without the install script requires way too many step that would imply duplicating the install script code in there")
 }
 

resources/aws/ec2/dedicated_host.go

@@ -58,6 +58,6 @@ func NewDedicatedHost(e aws.Environment, name string, args DedicatedHostArgs, op
 	return ec2.NewDedicatedHost(e.Ctx(),
 		e.Namer.ResourceName(name),
 		dedicatedHostArgs,
-		utils.MergeOptions(opts, e.WithProviders(config.ProviderAWS), pulumi.RetainOnDelete(true))..., // Retain on delete because deleting a dedicated host is not possible unless  it lived for at least 24 hours, the cleanup will be done by test-infra-cleaner
+		utils.MergeOptions(opts, e.WithProviders(config.ProviderAWS), pulumi.RetainOnDelete(true))..., // Retain on delete because deleting a dedicated host is not possible unless it lived for at least 24 hours, the cleanup will be done by test-infra-cleaner
 	)
 }

resources/aws/environmentDefaults.go

@@ -292,9 +292,9 @@ func tsePlaygroundDefault() environmentDefault {
 		ddInfra: ddInfra{
 			defaultVPCID: "vpc-0570ac09560a97693",
 			defaultSubnets: []SubnetConfig{
-				{ID: "subnet-0ec4b9823cf352b95", MacOSCompatible: true},
-				{ID: "subnet-0e9c45e996754e357", MacOSCompatible: false},
-				{ID: "subnet-070e1a6c79f6bc499", MacOSCompatible: true},
+				{ID: "subnet-0ec4b9823cf352b95", MacOSCompatible: true},  // us-east-1a
+				{ID: "subnet-0e9c45e996754e357", MacOSCompatible: false}, // us-east-1d
+				{ID: "subnet-070e1a6c79f6bc499", MacOSCompatible: true},  // us-east-1b
 			},
 			defaultSecurityGroups:      []string{"sg-091a00b0944f04fd2", "sg-073f15b823d4bb39a", "sg-0a3ec6b0ee295e826"},
 			defaultInstanceType:        "t3.medium",

scenarios/aws/ec2/vm_run.go

@@ -24,7 +24,6 @@ func VMRun(ctx *pulumi.Context) error {
 	}
 
 	osDesc := os.DescriptorFromString(env.InfraOSDescriptor(), os.AmazonLinuxECSDefault)
-
 	vm, err := NewVM(env, "vm", WithAMI(env.InfraOSImageID(), osDesc, osDesc.Architecture))
 	if err != nil {
 		return err