refactor: remove OptionalColumn, fold nullability into BoxedColumn/Un… #1266
haskell-ci.yml
on: push
fourmolu
13s
hlint
19s
Matrix: linux
Annotations
7 errors and 17 warnings
|
fourmolu
fourmolu detected unformatted files
|
|
hlint
HLint failed with status: 1. Warning (4), Suggestion (7)
|
|
Haskell-CI - Linux - ghc-9.12.2
Process completed with exit code 1.
|
|
Haskell-CI - Linux - ghc-9.4.8
Process completed with exit code 1.
|
|
Haskell-CI - Linux - ghc-9.8.4
Process completed with exit code 1.
|
|
Haskell-CI - Linux - ghc-9.10.3
Process completed with exit code 1.
|
|
Haskell-CI - Linux - ghc-9.6.7
Process completed with exit code 1.
|
|
fourmolu
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, haskell-actions/run-fourmolu@v11. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
hlint
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, haskell-actions/hlint-run@v2, haskell-actions/hlint-setup@v2. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
hlint:
src/DataFrame/Internal/Interpreter.hs#L225
Suggestion in sliceGroups in module DataFrame.Internal.Interpreter: Avoid lambda ▫︎ Found: "\\ b -> bitmapSlice (start i) (len i) b" ▫︎ Perhaps: "bitmapSlice (start i) (len i)"
|
|
hlint:
src/DataFrame/Internal/Interpreter.hs#L221
Suggestion in sliceGroups in module DataFrame.Internal.Interpreter: Avoid lambda ▫︎ Found: "\\ b -> bitmapSlice (start i) (len i) b" ▫︎ Perhaps: "bitmapSlice (start i) (len i)"
|
|
hlint:
src/DataFrame/Internal/Column.hs#L1075
Suggestion in expandColumn in module DataFrame.Internal.Column: Avoid lambda ▫︎ Found: "\\ i x -> VUM.unsafeWrite mv i x" ▫︎ Perhaps: "VUM.unsafeWrite mv"
|
|
hlint:
src/DataFrame/Internal/Column.hs#L604
Warning in gatherWithSentinel in module DataFrame.Internal.Column: Use when ▫︎ Found: "if idx >= 0 then\n VUM.unsafeWrite mv i (VU.unsafeIndex v idx)\nelse\n return ()" ▫︎ Perhaps: "Control.Monad.when (idx >= 0)\n $ VUM.unsafeWrite mv i (VU.unsafeIndex v idx)"
|
|
hlint:
src/DataFrame/Internal/Column.hs#L501
Suggestion in mapColumn in module DataFrame.Internal.Column: Avoid lambda using `infix` ▫︎ Found: "(\\ bm' -> bitmapTestBit bm' i)" ▫︎ Perhaps: "(`bitmapTestBit` i)"
|
|
hlint:
src/DataFrame/Internal/Column.hs#L496
Suggestion in mapColumn in module DataFrame.Internal.Column: Avoid lambda using `infix` ▫︎ Found: "(\\ bm' -> bitmapTestBit bm' i)" ▫︎ Perhaps: "(`bitmapTestBit` i)"
|
|
hlint:
src/DataFrame/Internal/Column.hs#L478
Suggestion in mapColumn in module DataFrame.Internal.Column: Avoid lambda using `infix` ▫︎ Found: "(\\ bm' -> bitmapTestBit bm' i)" ▫︎ Perhaps: "(`bitmapTestBit` i)"
|
|
hlint:
src/DataFrame/Internal/Column.hs#L473
Suggestion in mapColumn in module DataFrame.Internal.Column: Avoid lambda using `infix` ▫︎ Found: "(\\ bm' -> bitmapTestBit bm' i)" ▫︎ Perhaps: "(`bitmapTestBit` i)"
|
|
hlint:
src/DataFrame/Internal/Column.hs#L316
Warning in eqBoxedCols in module DataFrame.Internal.Column: Redundant if ▫︎ Found: "if nullA == nullB then go (i + 1) else False" ▫︎ Perhaps: "(nullA == nullB) && go (i + 1)"
|
|
hlint:
src/DataFrame/Internal/Column.hs#L171
Warning in fromMaybeVecUnboxed in module DataFrame.Internal.Column: Use forM_ ▫︎ Found: "case mx of\n Just x -> VUM.unsafeWrite mv i x\n Nothing -> return ()" ▫︎ Perhaps: "Data.Foldable.forM_ mx (VUM.unsafeWrite mv i)"
|
|
Haskell-CI - Linux - ghc-9.12.2
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache/restore@v4, actions/cache/save@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Haskell-CI - Linux - ghc-9.4.8
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache/restore@v4, actions/cache/save@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Haskell-CI - Linux - ghc-9.8.4
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache/restore@v4, actions/cache/save@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Haskell-CI - Linux - ghc-9.10.3
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache/restore@v4, actions/cache/save@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Haskell-CI - Linux - ghc-9.6.7
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache/restore@v4, actions/cache/save@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|