Restrict project eval page to peer review state

Author: alexeygrigorev

courses/tests/test_noindex.py

@@ -88,6 +88,9 @@ def test_project_list_has_noindex(self):
 
     def test_project_eval_has_noindex(self):
         """Test that project evaluation page has noindex meta tag."""
+        self.project.state = ProjectState.PEER_REVIEWING.value
+        self.project.save()
+
         self.client.login(
             username=self.credentials["username"],
             password=self.credentials["password"]

courses/tests/test_project_eval.py

@@ -551,7 +551,12 @@ def test_eval_view_authenticated_no_submission(self):
 
         self.assertContains(
             response,
-            "you did not submit your project",
+            "Because you did not submit your project, you cannot participate in peer review.",
+            status_code=200,
+        )
+        self.assertNotContains(
+            response,
+            "Mandatory progress",
             status_code=200,
         )
 
@@ -584,6 +589,33 @@ def test_eval_view_authenticated_with_submission(self):
             status_code=200,
         )
 
+    def test_eval_view_redirects_when_project_is_not_peer_reviewing(self):
+        """Test that eval view is only available during peer review."""
+        self.project.state = ProjectState.COMPLETED.value
+        self.project.save()
+
+        self.client.login(**credentials)
+
+        url = reverse(
+            "projects_eval",
+            args=[self.course.slug, self.project.slug],
+        )
+
+        response = self.client.get(url, follow=True)
+
+        self.assertRedirects(
+            response,
+            reverse(
+                "project",
+                args=[self.course.slug, self.project.slug],
+            ),
+        )
+
+        messages = list(response.context["messages"])
+        self.assertTrue(
+            any("not in peer review" in str(message) for message in messages)
+        )
+
     def test_list_view_authenticated_no_submission(self):
         """Test that list view doesn't show Add to Evaluation button when user hasn't submitted their project"""
         self.project.state = ProjectState.PEER_REVIEWING.value

courses/views/project.py

@@ -212,6 +212,18 @@ def projects_eval_view(request, course_slug, project_slug):
         Project, course=course, slug=project_slug
     )
 
+    if project.state != ProjectState.PEER_REVIEWING.value:
+        messages.error(
+            request,
+            "This project is not in peer review, so evaluations are not available.",
+            extra_tags="project",
+        )
+        return redirect(
+            "project",
+            course_slug=course.slug,
+            project_slug=project.slug,
+        )
+
     user = request.user
     is_authenticated = user.is_authenticated