Move admin edit button from leaderboard to score breakdown page

Author: alexeygrigorev

courses/templates/courses/leaderboard.html

@@ -34,11 +34,6 @@ <h2>Your Record</h2>
         <a href="{% url 'leaderboard_score_breakdown' course_slug=course.slug enrollment_id=enrollment.id %}">
           {{ enrollment.display_name }}
         </a>
-        {% if request.user.is_staff %}
-          <a href="{% url 'cadmin_enrollment_edit' course_slug=course.slug enrollment_id=enrollment.id %}" class="badge badge-primary ml-2" title="Admin: Edit Enrollment">
-            <i class="fas fa-cog"></i> Admin
-          </a>
-        {% endif %}
       </div>
       <div class="col-3 text-right">{{ enrollment.total_score }}</div>
     </div>

courses/templates/courses/leaderboard_score_breakdown.html

@@ -33,6 +33,14 @@ <h2>{{ enrollment.display_name }}</h2>
 
 <p><strong>Total Score:</strong> {{ enrollment.total_score }}</p>
 
+{% if request.user.is_staff %}
+  <p>
+    <a href="{% url 'cadmin_enrollment_edit' course_slug=enrollment.course.slug enrollment_id=enrollment.id %}" class="badge badge-primary" title="Admin: Edit Enrollment">
+      <i class="fas fa-cog"></i> Admin
+    </a>
+  </p>
+{% endif %}
+
 <h3 class="mt-4">Homework submissions</h3>
 {% for submission in submissions %}
   {% if submission.homework.is_scored %}

courses/tests/test_leaderboard.py

@@ -5,6 +5,8 @@
 from datetime import timedelta
 from django.core.cache import cache
 
+from django.urls import reverse
+
 from courses.models import (
     Course,
     Homework,
@@ -155,3 +157,51 @@ def test_leaderboard_cache_invalidation(self):
 
         # Cache should be invalidated (None)
         self.assertIsNone(cache.get(cache_key))
+
+    def test_score_breakdown_admin_button_visible_for_staff(self):
+        """Test that admin edit button is visible on score breakdown page for staff users"""
+        enrollment = self.create_student("student1")
+        admin_user = User.objects.create_user(username="admin", is_staff=True)
+
+        self.client.force_login(admin_user)
+        url = reverse("leaderboard_score_breakdown", kwargs={
+            "course_slug": self.course.slug,
+            "enrollment_id": enrollment.id,
+        })
+        response = self.client.get(url)
+
+        self.assertEqual(response.status_code, 200)
+        admin_edit_url = reverse("cadmin_enrollment_edit", kwargs={
+            "course_slug": self.course.slug,
+            "enrollment_id": enrollment.id,
+        })
+        self.assertContains(response, admin_edit_url)
+        self.assertContains(response, "fa-cog")
+
+    def test_score_breakdown_admin_button_hidden_for_regular_user(self):
+        """Test that admin edit button is hidden on score breakdown page for regular users"""
+        enrollment = self.create_student("student1")
+        regular_user = User.objects.create_user(username="regular", is_staff=False)
+
+        self.client.force_login(regular_user)
+        url = reverse("leaderboard_score_breakdown", kwargs={
+            "course_slug": self.course.slug,
+            "enrollment_id": enrollment.id,
+        })
+        response = self.client.get(url)
+
+        self.assertEqual(response.status_code, 200)
+        self.assertNotContains(response, "fa-cog")
+
+    def test_score_breakdown_admin_button_hidden_for_anonymous(self):
+        """Test that admin edit button is hidden on score breakdown page for anonymous users"""
+        enrollment = self.create_student("student1")
+
+        url = reverse("leaderboard_score_breakdown", kwargs={
+            "course_slug": self.course.slug,
+            "enrollment_id": enrollment.id,
+        })
+        response = self.client.get(url)
+
+        self.assertEqual(response.status_code, 200)
+        self.assertNotContains(response, "fa-cog")