Address code review feedback - fix auto-uncheck and add constants

Co-authored-by: alexeygrigorev <875246+alexeygrigorev@users.noreply.github.com>

Author: Copilot

cadmin/templates/cadmin/homework_submissions.html

@@ -83,6 +83,8 @@ <h2>{{ homework.title }} - Submissions</h2>
 </div>
 
 <script>
+const MISSING_SCORE_VALUE = -999; // Used for sorting when score is missing
+
 function sortTable() {
   const table = document.getElementById('submissionsTable');
   const tbody = table.querySelector('tbody');
@@ -102,8 +104,8 @@ <h2>{{ homework.title }} - Submissions</h2>
     } else if (sortBy === 'score') {
       aVal = a.cells[2].textContent.trim();
       bVal = b.cells[2].textContent.trim();
-      aVal = aVal === '-' ? -999 : parseFloat(aVal);
-      bVal = bVal === '-' ? -999 : parseFloat(bVal);
+      aVal = aVal === '-' ? MISSING_SCORE_VALUE : parseFloat(aVal);
+      bVal = bVal === '-' ? MISSING_SCORE_VALUE : parseFloat(bVal);
       return bVal - aVal; // Descending
     }
     return 0;

cadmin/templates/cadmin/project_submission_edit.html

@@ -187,9 +187,13 @@ <h4>Overall Results</h4>
       totalField.value = total;
     }
 
-    // Auto-check "passed" if total >= passing threshold
-    if (passedCheckbox && total >= passingThreshold) {
-      passedCheckbox.checked = true;
+    // Auto-check or uncheck "passed" based on total score vs passing threshold
+    if (passedCheckbox) {
+      if (total >= passingThreshold) {
+        passedCheckbox.checked = true;
+      } else {
+        passedCheckbox.checked = false;
+      }
     }
 
     return total;

cadmin/templates/cadmin/project_submissions.html

@@ -111,6 +111,8 @@ <h2>{{ project.title }} - Submissions</h2>
 {% endif %}
 
 <script>
+const MISSING_SCORE_VALUE = -999; // Used for sorting when score is missing
+
 function copyEmails() {
   const emails = [
     {% for submission in submissions %}
@@ -155,14 +157,14 @@ <h2>{{ project.title }} - Submissions</h2>
     } else if (sortBy === 'project_score') {
       aVal = a.cells[2].textContent.trim();
       bVal = b.cells[2].textContent.trim();
-      aVal = aVal === '-' ? -999 : parseFloat(aVal);
-      bVal = bVal === '-' ? -999 : parseFloat(bVal);
+      aVal = aVal === '-' ? MISSING_SCORE_VALUE : parseFloat(aVal);
+      bVal = bVal === '-' ? MISSING_SCORE_VALUE : parseFloat(bVal);
       return bVal - aVal; // Descending
     } else if (sortBy === 'total_score') {
       aVal = a.cells[3].textContent.trim();
       bVal = b.cells[3].textContent.trim();
-      aVal = aVal === '-' ? -999 : parseFloat(aVal);
-      bVal = bVal === '-' ? -999 : parseFloat(bVal);
+      aVal = aVal === '-' ? MISSING_SCORE_VALUE : parseFloat(aVal);
+      bVal = bVal === '-' ? MISSING_SCORE_VALUE : parseFloat(bVal);
       return bVal - aVal; // Descending
     }
     return 0;