comments field - configurable in course now

Author: alexeygrigorev

courses/migrations/0019_remove_homework_problems_comments_field_and_more.py

@@ -0,0 +1,22 @@
+# Generated by Django 5.1.7 on 2025-06-18 10:44
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('courses', '0018_course_finished'),
+    ]
+
+    operations = [
+        migrations.RemoveField(
+            model_name='homework',
+            name='problems_comments_field',
+        ),
+        migrations.AddField(
+            model_name='course',
+            name='homework_problems_comments_field',
+            field=models.BooleanField(default=False, help_text='Include field for problems and comments in homework'),
+        ),
+    ]

courses/models/course.py

@@ -42,6 +42,11 @@ class Course(models.Model):
         help_text="The URL of the FAQ document for the course.",
     )
 
+    homework_problems_comments_field = models.BooleanField(
+        default=False,
+        help_text="Include field for problems and comments in homework",
+    )
+
     def __str__(self):
         return self.title
 

courses/models/homework.py

@@ -39,10 +39,7 @@ class Homework(models.Model):
         default=True,
         help_text="Include field for time spent on homework",
     )
-    problems_comments_field = models.BooleanField(
-        default=True,
-        help_text="Include field for problems and comments",
-    )
+
     faq_contribution_field = models.BooleanField(
         default=True, help_text="Include field for FAQ contributions"
     )

courses/templates/homework/homework.html

@@ -201,6 +201,20 @@ <h3 class="mb-3">Questions</h3>
       </div>
     {% endif %}
 
+    {% if course.homework_problems_comments_field %}
+      <div class="mb-3 question">
+        <label for="problems_comments" class="question-text">
+          Problems or comments <span class="text-muted">(optional)</span>
+        </label>
+        <textarea
+          class="form-control"
+          name="problems_comments"
+          id="problems_comments"
+          {% if disabled %} disabled {% endif %}
+        >{{ submission.problems_comments|default:'' }}</textarea>
+      </div>
+    {% endif %}
+
     {% if course.faq_document_url and homework.faq_contribution_field %}
       <div class="mb-3 question">
         <label for="faq_contribution" class="question-text">

courses/tests/test_data.py

@@ -151,10 +151,6 @@ def test_homework_data_view(self):
             actual_result["homework"]["time_spent_homework_field"],
             self.homework.time_spent_homework_field,
         )
-        self.assertEqual(
-            actual_result["homework"]["problems_comments_field"],
-            self.homework.problems_comments_field,
-        )
         self.assertEqual(
             actual_result["homework"]["faq_contribution_field"],
             self.homework.faq_contribution_field,

courses/tests/test_homework.py

@@ -449,7 +449,9 @@ def test_homework_detail_with_scored_homework(self):
 
         # make sure we have the latest version of the homework
         self.homework = Homework.objects.get(id=self.homework.id)
-        self.assertEqual(self.homework.state, HomeworkState.SCORED.value)
+        self.assertEqual(
+            self.homework.state, HomeworkState.SCORED.value
+        )
         self.assertTrue(self.homework.is_scored())
 
         self.client.login(**credentials)
@@ -814,13 +816,14 @@ def test_homework_detail_submission_post_with_submissions(
         self.assertEqual(answer6.answer_text, "1,2")
 
     def test_submit_homework_with_all_fields(self):
+        self.course.homework_problems_comments_field = True
+        self.course.save()
+
         self.homework.homework_url_field = True
         self.homework.learning_in_public_cap = 7
         self.homework.time_spent_lectures_field = True
         self.homework.time_spent_homework_field = True
-        self.homework.problems_comments_field = True
         self.homework.faq_contribution_field = True
-
         self.homework.save()
 
         self.client.login(**credentials)
@@ -969,8 +972,7 @@ def test_submit_homework_learning_in_public_empty_and_duplicates(
             "learning_in_public_links[]": [
                 "https://httpbin.org/status/200",
                 "https://httpbin.org/status/200",
-                "https://github.com/DataTalksClub"
-                "",
+                "https://github.com/DataTalksClub",
             ],
         }
 
@@ -993,7 +995,7 @@ def test_submit_homework_learning_in_public_empty_and_duplicates(
 
         expected_learning_in_public_links = [
             "https://httpbin.org/status/200",
-            "https://github.com/DataTalksClub"
+            "https://github.com/DataTalksClub",
         ]
         self.assertEqual(
             submission.learning_in_public_links,

courses/views/homework.py

@@ -237,7 +237,7 @@ def process_homework_submission(
         ):
             submission.time_spent_homework = float(time_spent_homework)
 
-    if homework.problems_comments_field:
+    if course.homework_problems_comments_field:
         problems_comments = request.POST.get("problems_comments", "")
         submission.problems_comments = problems_comments.strip()