Add leaderboard record flagging

Author: alexeygrigorev

cadmin/templates/cadmin/course_admin.html

@@ -130,10 +130,15 @@ <h2 class="text-base font-semibold app-heading">Student support</h2>
         <p class="text-xs font-semibold uppercase app-muted">Hidden</p>
         <p class="mt-1 text-lg font-semibold app-heading">{{ support_metrics.hidden_leaderboard }}</p>
       </div>
+      <div class="rounded-md app-surface-muted p-3">
+        <p class="text-xs font-semibold uppercase app-muted">Open flags</p>
+        <p class="mt-1 text-lg font-semibold app-heading">{{ support_metrics.open_complaints }}</p>
+      </div>
     </div>
     <div class="mt-4 flex flex-wrap gap-2">
       <a href="{% url 'cadmin_enrollments' course.slug %}" class="primer-button cadmin-primary">Find student</a>
       <a href="{% url 'leaderboard' course.slug %}" class="primer-button primer-button-secondary">Open leaderboard</a>
+      <a href="{% url 'cadmin_leaderboard_complaints' course.slug %}" class="primer-button primer-button-secondary">Review flags</a>
     </div>
   </article>
 </section>

cadmin/templates/cadmin/leaderboard_complaints.html

@@ -0,0 +1,102 @@
+{% extends 'cadmin/base.html' %}
+
+{% block title %}Leaderboard flags - {{ course.title }}{% endblock %}
+
+{% block breadcrumbs %}
+  <li><a href="{% url 'cadmin_course_list' %}">Course Admin</a></li>
+  <li><a href="{% url 'cadmin_course' course.slug %}">{{ course.title }}</a></li>
+  <li>Leaderboard flags</li>
+{% endblock %}
+
+{% block cadmin_content %}
+<section class="border-b app-border pb-5">
+  <div class="flex flex-col gap-4 lg:flex-row lg:items-start lg:justify-between">
+    <div>
+      <p class="text-sm font-semibold uppercase tracking-wide app-muted">Leaderboard moderation</p>
+      <h1 class="mt-2 text-2xl font-semibold app-heading md:text-3xl">Flags for {{ course.title }}</h1>
+      <p class="mt-1 text-sm app-muted">Student records are sorted by open flag count, then total flag count.</p>
+    </div>
+    <div class="flex flex-wrap gap-2">
+      <a href="{% url 'cadmin_course' course.slug %}" class="primer-button primer-button-secondary">Back to Course Admin</a>
+      <a href="{% url 'leaderboard' course.slug %}" class="primer-button">View Leaderboard</a>
+    </div>
+  </div>
+
+  <div class="mt-4 grid grid-cols-2 gap-2 sm:max-w-md">
+    <div class="rounded-md border app-border app-surface-muted px-3 py-2">
+      <span class="block text-xs font-semibold uppercase app-muted">Open</span>
+      <span class="mt-1 block text-lg font-semibold app-heading">{{ open_complaints_count }}</span>
+    </div>
+    <div class="rounded-md border app-border app-surface-muted px-3 py-2">
+      <span class="block text-xs font-semibold uppercase app-muted">Total</span>
+      <span class="mt-1 block text-lg font-semibold app-heading">{{ total_complaints_count }}</span>
+    </div>
+  </div>
+</section>
+
+<section class="mt-6 space-y-4">
+  {% for row in enrollment_rows %}
+    {% with enrollment=row.enrollment %}
+      <article class="overflow-hidden rounded-md border app-border app-surface">
+        <div class="border-b app-border app-surface-muted px-4 py-3">
+          <div class="flex flex-col gap-3 md:flex-row md:items-center md:justify-between">
+            <div>
+              <h2 class="font-semibold app-heading">{{ enrollment.display_name }}</h2>
+              <p class="mt-1 text-sm app-muted">
+                {{ enrollment.student.email|default:enrollment.student.username }} ·
+                position {% if enrollment.position_on_leaderboard %}{{ enrollment.position_on_leaderboard }}{% else %}-{% endif %} ·
+                {{ enrollment.total_score }} points
+              </p>
+            </div>
+            <div class="flex flex-wrap gap-2">
+              <span class="rounded-md app-badge-danger px-2 py-1 text-sm font-semibold">{{ enrollment.open_complaints }} open</span>
+              <span class="rounded-md app-badge-neutral px-2 py-1 text-sm font-semibold">{{ enrollment.total_complaints }} total</span>
+              <a href="{% url 'leaderboard_score_breakdown' course.slug enrollment.id %}" class="primer-button primer-button-secondary">Scores</a>
+              <a href="{% url 'cadmin_enrollment_edit' course.slug enrollment.id %}" class="primer-button primer-button-secondary">Manage</a>
+            </div>
+          </div>
+        </div>
+        <div class="divide-y app-divide">
+          {% for complaint in row.complaints %}
+            <div class="px-4 py-4">
+              <div class="flex flex-col gap-3 md:flex-row md:items-start md:justify-between">
+                <div class="min-w-0">
+                  <div class="flex flex-wrap items-center gap-2">
+                    <span class="font-medium app-heading">{{ complaint.get_issue_type_display }}</span>
+                    {% if complaint.resolved %}
+                      <span class="rounded-full app-badge-success px-2 py-0.5 text-xs font-medium">Resolved</span>
+                    {% else %}
+                      <span class="rounded-full app-badge-warning px-2 py-0.5 text-xs font-medium">Open</span>
+                    {% endif %}
+                  </div>
+                  <p class="mt-1 text-xs app-muted">
+                    Reported {{ complaint.created_at|date:"Y-m-d H:i" }}
+                    {% if complaint.reporter %}by {{ complaint.reporter.email|default:complaint.reporter.username }}{% endif %}
+                  </p>
+                  <p class="mt-3 whitespace-pre-wrap text-sm app-text">{{ complaint.description }}</p>
+                  {% if complaint.resolved %}
+                    <p class="mt-2 text-xs app-muted">
+                      Resolved {{ complaint.resolved_at|date:"Y-m-d H:i" }}
+                      {% if complaint.resolved_by %}by {{ complaint.resolved_by.email|default:complaint.resolved_by.username }}{% endif %}
+                    </p>
+                  {% endif %}
+                </div>
+                {% if not complaint.resolved %}
+                  <form method="post" action="{% url 'cadmin_leaderboard_complaint_resolve' course.slug complaint.id %}">
+                    {% csrf_token %}
+                    <button type="submit" class="primer-button">Mark resolved</button>
+                  </form>
+                {% endif %}
+              </div>
+            </div>
+          {% endfor %}
+        </div>
+      </article>
+    {% endwith %}
+  {% empty %}
+    <div class="rounded-md border app-border app-surface p-6">
+      <p class="text-sm app-muted">No leaderboard flags yet.</p>
+    </div>
+  {% endfor %}
+</section>
+{% endblock %}

cadmin/tests/test_views.py

@@ -17,6 +17,7 @@
     ReviewCriteria,
     ReviewCriteriaTypes,
     ProjectEvaluationScore,
+    LeaderboardComplaint,
 )
 
 
@@ -121,6 +122,95 @@ def test_course_admin_staff_allowed(self):
         self.assertContains(response, self.course.title)
         self.assertContains(response, "Admin Panel")
 
+    def test_leaderboard_complaints_sorted_by_open_count(self):
+        self.client.login(username="admin@test.com", password="admin123")
+        reporter = User.objects.create_user(
+            username="reporter@test.com",
+            email="reporter@test.com",
+            password="12345",
+        )
+        first = Enrollment.objects.create(
+            student=User.objects.create_user(username="first@test.com"),
+            course=self.course,
+            display_name="First Student",
+            total_score=10,
+            position_on_leaderboard=2,
+        )
+        second = Enrollment.objects.create(
+            student=User.objects.create_user(username="second@test.com"),
+            course=self.course,
+            display_name="Second Student",
+            total_score=20,
+            position_on_leaderboard=1,
+        )
+        LeaderboardComplaint.objects.create(
+            enrollment=first,
+            reporter=reporter,
+            issue_type=LeaderboardComplaint.IssueType.HOMEWORK,
+            description="Incorrect homework.",
+        )
+        LeaderboardComplaint.objects.create(
+            enrollment=second,
+            reporter=reporter,
+            issue_type=LeaderboardComplaint.IssueType.PROJECT,
+            description="Incorrect project.",
+        )
+        LeaderboardComplaint.objects.create(
+            enrollment=second,
+            reporter=reporter,
+            issue_type=LeaderboardComplaint.IssueType.LEARNING_IN_PUBLIC,
+            description="Incorrect learning links.",
+        )
+
+        response = self.client.get(
+            reverse(
+                "cadmin_leaderboard_complaints",
+                kwargs={"course_slug": self.course.slug},
+            )
+        )
+
+        self.assertEqual(response.status_code, 200)
+        rows = response.context["enrollment_rows"]
+        self.assertEqual(rows[0]["enrollment"], second)
+        self.assertEqual(rows[0]["enrollment"].open_complaints, 2)
+        self.assertContains(response, "Second Student")
+
+    def test_staff_can_resolve_leaderboard_complaint(self):
+        self.client.login(username="admin@test.com", password="admin123")
+        enrollment = Enrollment.objects.create(
+            student=self.user,
+            course=self.course,
+            display_name="Reported Student",
+            total_score=10,
+        )
+        complaint = LeaderboardComplaint.objects.create(
+            enrollment=enrollment,
+            reporter=self.user,
+            issue_type=LeaderboardComplaint.IssueType.HOMEWORK,
+            description="Incorrect homework.",
+        )
+
+        response = self.client.post(
+            reverse(
+                "cadmin_leaderboard_complaint_resolve",
+                kwargs={
+                    "course_slug": self.course.slug,
+                    "complaint_id": complaint.id,
+                },
+            )
+        )
+
+        self.assertRedirects(
+            response,
+            reverse(
+                "cadmin_leaderboard_complaints",
+                kwargs={"course_slug": self.course.slug},
+            ),
+        )
+        complaint.refresh_from_db()
+        self.assertTrue(complaint.resolved)
+        self.assertEqual(complaint.resolved_by, self.admin_user)
+
     def test_homework_submissions_redirect_from_courses(self):
         """Test that homework submissions view redirects to cadmin"""
         self.client.login(username="admin@test.com", password="admin123")

cadmin/urls.py

@@ -50,6 +50,16 @@
         views.enrollments_list,
         name="cadmin_enrollments",
     ),
+    path(
+        "<slug:course_slug>/leaderboard-complaints/",
+        views.leaderboard_complaints,
+        name="cadmin_leaderboard_complaints",
+    ),
+    path(
+        "<slug:course_slug>/leaderboard-complaints/<int:complaint_id>/resolve",
+        views.leaderboard_complaint_resolve,
+        name="cadmin_leaderboard_complaint_resolve",
+    ),
     path(
         "<slug:course_slug>/enrollment/<int:enrollment_id>/edit",
         views.enrollment_edit,

cadmin/views.py

@@ -7,6 +7,7 @@
 from django.shortcuts import render, get_object_or_404, redirect
 from django.contrib import messages
 from django.contrib.auth.decorators import user_passes_test
+from django.utils import timezone
 
 from courses.models import (
     Course,
@@ -23,6 +24,7 @@
     ReviewCriteria,
     ProjectEvaluationScore,
     Enrollment,
+    LeaderboardComplaint,
 )
 from courses.scoring import (
     score_homework_submissions,
@@ -109,13 +111,18 @@ def course_admin(request, course_slug):
         "disabled_lip": enrollments.filter(disable_learning_in_public=True).count(),
         "zero_score": enrollments.filter(total_score=0).count(),
         "hidden_leaderboard": enrollments.filter(display_on_leaderboard=False).count(),
+        "open_complaints": LeaderboardComplaint.objects.filter(
+            enrollment__course=course,
+            resolved=False,
+        ).count(),
     }
     needs_attention_count = (
         len(homework_needing_score)
         + len(projects_needing_reviews)
         + len(projects_needing_score)
         + support_metrics["disabled_lip"]
         + support_metrics["hidden_leaderboard"]
+        + support_metrics["open_complaints"]
     )
     project_action_count = len(projects_needing_reviews) + len(projects_needing_score)
 
@@ -620,6 +627,76 @@ def enrollments_list(request, course_slug):
     return render(request, "cadmin/enrollments.html", context)
 
 
+@staff_required
+def leaderboard_complaints(request, course_slug):
+    course = get_object_or_404(Course, slug=course_slug)
+
+    enrollments = (
+        Enrollment.objects.filter(course=course)
+        .select_related("student")
+        .annotate(
+            open_complaints=Count(
+                "complaints",
+                filter=Q(complaints__resolved=False),
+            ),
+            total_complaints=Count("complaints"),
+        )
+        .filter(total_complaints__gt=0)
+        .order_by("-open_complaints", "-total_complaints", "position_on_leaderboard")
+    )
+
+    complaints_by_enrollment = defaultdict(list)
+    complaints = (
+        LeaderboardComplaint.objects.filter(enrollment__course=course)
+        .select_related("enrollment", "reporter", "resolved_by")
+        .order_by("resolved", "-created_at")
+    )
+    for complaint in complaints:
+        complaints_by_enrollment[complaint.enrollment_id].append(complaint)
+
+    enrollment_rows = []
+    for enrollment in enrollments:
+        enrollment_rows.append(
+            {
+                "enrollment": enrollment,
+                "complaints": complaints_by_enrollment[enrollment.id],
+            }
+        )
+
+    context = {
+        "course": course,
+        "enrollment_rows": enrollment_rows,
+        "open_complaints_count": LeaderboardComplaint.objects.filter(
+            enrollment__course=course,
+            resolved=False,
+        ).count(),
+        "total_complaints_count": LeaderboardComplaint.objects.filter(
+            enrollment__course=course,
+        ).count(),
+    }
+    return render(request, "cadmin/leaderboard_complaints.html", context)
+
+
+@staff_required
+def leaderboard_complaint_resolve(request, course_slug, complaint_id):
+    if request.method != "POST":
+        return redirect("cadmin_leaderboard_complaints", course_slug=course_slug)
+
+    course = get_object_or_404(Course, slug=course_slug)
+    complaint = get_object_or_404(
+        LeaderboardComplaint,
+        id=complaint_id,
+        enrollment__course=course,
+    )
+    complaint.resolved = True
+    complaint.resolved_at = timezone.now()
+    complaint.resolved_by = request.user
+    complaint.save(update_fields=["resolved", "resolved_at", "resolved_by"])
+
+    messages.success(request, "Flag marked as resolved.")
+    return redirect("cadmin_leaderboard_complaints", course_slug=course_slug)
+
+
 @staff_required
 def enrollment_edit(request, course_slug, enrollment_id):
     """Edit an enrollment - mainly to disable learning in public"""

courses/admin/course.py

@@ -10,7 +10,7 @@
 
 from django.contrib import messages
 
-from courses.models import Course, ReviewCriteria
+from courses.models import Course, LeaderboardComplaint, ReviewCriteria
 from courses.scoring import update_leaderboard
 from courses.validators import validate_review_criteria_options
 
@@ -130,3 +130,22 @@ class CourseAdmin(ModelAdmin):
     actions = [update_leaderboard_admin, duplicate_course]
     inlines = [CriteriaInline]
     list_display = ["title", "visible", "finished"]
+
+
+@admin.register(LeaderboardComplaint)
+class LeaderboardComplaintAdmin(ModelAdmin):
+    list_display = [
+        "enrollment",
+        "issue_type",
+        "resolved",
+        "created_at",
+        "resolved_at",
+    ]
+    list_filter = ["resolved", "issue_type", "enrollment__course"]
+    search_fields = [
+        "description",
+        "enrollment__display_name",
+        "enrollment__student__email",
+        "reporter__email",
+    ]
+    readonly_fields = ["created_at"]