moving scores to pass to course, not project

Author: alexeygrigorev

.dockerignore

@@ -3,4 +3,7 @@ terraform/
 Dockerfile
 Makefile
 README.md
-.venv
+.venv
+.envrc
+.envrc_template
+.github

Makefile

@@ -93,6 +93,10 @@ deploy_prod:
 	bash deploy/deploy_prod.sh
 
 
+sync: ## Install dev dependencies
+sync:
+	uv sync --dev
+
 
 help:    ## Show this help.
 	@fgrep -h "##" $(MAKEFILE_LIST) | fgrep -v fgrep | sed -e 's/\\$$//' | sed -e 's/##//'

courses/admin/course.py

@@ -74,6 +74,7 @@ def duplicate_course(modeladmin, request, queryset):
             first_homework_scored=False,
             finished=False,
             faq_document_url=course.faq_document_url,
+            project_passing_score=course.project_passing_score,
         )
 
         # Copy review criteria with all fields

courses/migrations/0020_remove_project_points_to_pass_and_more.py

@@ -0,0 +1,22 @@
+# Generated by Django 5.2.4 on 2025-07-17 10:35
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('courses', '0019_remove_homework_problems_comments_field_and_more'),
+    ]
+
+    operations = [
+        migrations.RemoveField(
+            model_name='project',
+            name='points_to_pass',
+        ),
+        migrations.AddField(
+            model_name='course',
+            name='project_passing_score',
+            field=models.IntegerField(default=0, help_text='Minimum score required to pass any project in this course'),
+        ),
+    ]

courses/models/course.py

@@ -47,6 +47,11 @@ class Course(models.Model):
         help_text="Include field for problems and comments in homework",
     )
 
+    project_passing_score = models.IntegerField(
+        default=0,
+        help_text="Minimum score required to pass any project in this course",
+    )
+
     def __str__(self):
         return self.title
 

courses/models/project.py

@@ -42,8 +42,6 @@ class Project(models.Model):
     points_for_peer_review = models.IntegerField(default=3)
     time_spent_evaluation_field = models.BooleanField(default=True)
 
-    points_to_pass = models.IntegerField(default=0)
-
     state = models.CharField(
         max_length=2,
         choices=[(state.value, state.name) for state in ProjectState],
@@ -53,6 +51,11 @@ class Project(models.Model):
     def __str__(self):
         return self.title
 
+    @property
+    def points_to_pass(self):
+        """Get the passing score from the course"""
+        return self.course.project_passing_score
+
     class Meta:
         unique_together = ("course", "slug")
 

courses/projects.py

@@ -55,11 +55,11 @@ def select_random_assignment(
 
     if n <= num_projects_to_review:
         raise ValueError(
-            "The number of projects to review should be greater than the number of submissions. " + 
-            f"Number of projects to review: {num_projects_to_review}, Number of submissions: {n}"
+            "The number of projects to review should be greater than the number of submissions. "
+            + f"Number of projects to review: {num_projects_to_review}, Number of submissions: {n}"
         )
 
-    random.seed(seed)    
+    random.seed(seed)
 
     submissions_list = list(submissions)
 
@@ -217,7 +217,7 @@ def score_project(project: Project) -> tuple[ProjectActionStatus, str]:
         if project.points_to_pass == 0:
             return (
                 ProjectActionStatus.FAIL,
-                "Project has no points to pass. Update the `point_to_pass` field to greater than zero value",
+                "Project has no points to pass. Update the course's `project_passing_score` field to greater than zero value",
             )
 
         if project.state != ProjectState.PEER_REVIEWING.value:
@@ -302,7 +302,8 @@ def score_project(project: Project) -> tuple[ProjectActionStatus, str]:
                     num_mandatory_projects_reviewed += 1
 
             submission.peer_review_score = (
-                num_mandatory_projects_reviewed * project.points_for_peer_review
+                num_mandatory_projects_reviewed
+                * project.points_for_peer_review
             )
 
             learning_in_public_cap_project = (
@@ -369,7 +370,7 @@ def score_project(project: Project) -> tuple[ProjectActionStatus, str]:
             ) and submission.reviewed_enough_peers
 
             submissions_to_update.append(submission)
-            
+
             if submission.passed:
                 passed += 1
 

courses/tests/test_course.py

@@ -447,6 +447,7 @@ def test_duplicate_course(self):
         self.course.slug = f"test-course-{current_year - 1}"
         self.course.social_media_hashtag = "#testcourse2023"
         self.course.faq_document_url = "https://example.com/faq"
+        self.course.project_passing_score = 75
         self.course.save()
 
         # Execute the duplicate action
@@ -479,6 +480,9 @@ def test_duplicate_course(self):
         self.assertEqual(
             new_course.faq_document_url, self.course.faq_document_url
         )
+        self.assertEqual(
+            new_course.project_passing_score, self.course.project_passing_score
+        )
         self.assertFalse(new_course.first_homework_scored)
         self.assertFalse(new_course.finished)
 

courses/tests/test_project_score.py

@@ -56,6 +56,10 @@ def setUp(self):
             course=self.course,
         )
 
+        # Set the course's project passing score
+        self.course.project_passing_score = 70
+        self.course.save()
+
         self.project = Project.objects.create(
             course=self.course,
             slug="test-project",
@@ -67,7 +71,6 @@ def setUp(self):
             learning_in_public_cap_project=5,
             learning_in_public_cap_review=3,
             number_of_peers_to_evaluate=3,
-            points_to_pass=70,
         )
 
         self.submission = ProjectSubmission.objects.create(
@@ -386,8 +389,8 @@ def test_project_passed(self):
         scores = [3, 3, 0]
         expected_project_score = 3
 
-        self.project.points_to_pass = 3
-        self.project.save()
+        self.course.project_passing_score = 3
+        self.course.save()
 
         answers_and_scores = list(zip(answers, scores))
 
@@ -425,8 +428,8 @@ def test_project_not_passed(self):
         scores = [3, 0, 0]
         expected_project_score = 0
 
-        self.project.points_to_pass = 3
-        self.project.save()
+        self.course.project_passing_score = 3
+        self.course.save()
 
         answers_and_scores = list(zip(answers, scores))
 
@@ -452,8 +455,8 @@ def test_project_not_passed(self):
         )
 
     def test_not_scoring_when_passing_score_is_0(self):
-        self.project.points_to_pass = 0
-        self.project.save()
+        self.course.project_passing_score = 0
+        self.course.save()
 
         status, _ = score_project(self.project)
         self.assertEqual(status, ProjectActionStatus.FAIL)
@@ -478,8 +481,8 @@ def test_project_passed_with_optional(self):
         scores = [3, 3, 0]
         expected_project_score = 3
 
-        self.project.points_to_pass = 3
-        self.project.save()
+        self.course.project_passing_score = 3
+        self.course.save()
 
         answers_and_scores = list(zip(answers, scores))
 

courses/views/data.py

@@ -103,10 +103,14 @@ def project_data_view(request, course_slug: str, project_slug: str):
         }
         submission_data.append(submission_dict)
 
+    # Get project data and add the points_to_pass property
+    project_data = model_to_dict(project)
+    project_data['points_to_pass'] = project.points_to_pass
+
     # Compile the result
     result = {
         "course": course_data,
-        "project": model_to_dict(project),
+        "project": project_data,
         "submissions": submission_data,
     }