mocking http calls

Author: alexeygrigorev

Makefile

@@ -26,7 +26,7 @@ user:
 
 tests: ## Run tests
 tests:
-	uv run python manage.py test courses.tests
+	uv run python manage.py test courses.tests --timing --durations 30
 
 
 data: ## Add data to database

courses/tests/test_data.py

@@ -66,7 +66,6 @@ def test_homework_data_view(self):
             homework_link="https://github.com/DataTalksClub",
         )
 
-        self.submission.full_clean()
         self.submission.save()
 
         self.question = Question.objects.create(
@@ -235,7 +234,6 @@ def test_project_data_view(self):
             commit_id="abcd1234",
         )
 
-        self.project_submission.full_clean()
         self.project_submission.save()
 
         url = reverse(
@@ -442,47 +440,6 @@ def test_project_data_view(self):
             submission["passed"], expected_submission["passed"]
         )
 
-    def test_homework_submission_with_404_url(self):
-        self.homework = Homework.objects.create(
-            course=self.course,
-            title="Test Homework",
-            description="Test Homework Description",
-            due_date=timezone.now() + timezone.timedelta(days=7),
-            state=HomeworkState.OPEN.value,
-            slug="test-homework",
-        )
-
-        self.submission = Submission(
-            homework=self.homework,
-            student=self.user,
-            enrollment=self.enrollment,
-            homework_link="https://httpbin.org/status/404",
-        )
-        with self.assertRaises(ValidationError):
-            self.submission.full_clean()
-
-    def test_project_submission_with_404_url(self):
-        self.project = Project.objects.create(
-            course=self.course,
-            slug="test-project",
-            title="Test Project",
-            description="Description",
-            submission_due_date=timezone.now()
-            + timezone.timedelta(days=7),
-            peer_review_due_date=timezone.now()
-            + timezone.timedelta(days=14),
-        )
-
-        self.project_submission = ProjectSubmission(
-            project=self.project,
-            student=self.user,
-            enrollment=self.enrollment,
-            github_link="https://httpbin.org/status/404",
-            commit_id="abcd1234",
-        )
-        with self.assertRaises(ValidationError):
-            self.project_submission.full_clean()
-
     def test_graduate_data_view(self):
         """Test that only students who passed enough projects are returned."""
 

courses/tests/test_homework.py

@@ -815,7 +815,12 @@ def test_homework_detail_submission_post_with_submissions(
         answer6 = answers.get(question=self.question6)
         self.assertEqual(answer6.answer_text, "1,2")
 
-    def test_submit_homework_with_all_fields(self):
+    @mock.patch("requests.get")
+    def test_submit_homework_with_all_fields(self, mock_get):
+        mock_response = mock.Mock()
+        mock_response.status_code = 200
+        mock_get.return_value = mock_response
+
         self.course.homework_problems_comments_field = True
         self.course.save()
 
@@ -896,7 +901,14 @@ def test_submit_homework_with_all_fields(self):
             post_data["faq_contribution"],
         )
 
-    def test_submit_homework_with_all_fields_optional_empty(self):
+    @mock.patch("requests.get")
+    def test_submit_homework_with_all_fields_optional_empty(
+        self, mock_get
+    ):
+        mock_response = mock.Mock()
+        mock_response.status_code = 200
+        mock_get.return_value = mock_response
+
         self.homework.homework_url_field = True
         self.homework.learning_in_public_cap = 7
         self.homework.time_spent_lectures_field = True
@@ -916,7 +928,7 @@ def test_submit_homework_with_all_fields_optional_empty(self):
             f"answer_{self.question4.id}": ["3"],
             f"answer_{self.question5.id}": ["3.141516"],
             f"answer_{self.question6.id}": ["1", "2"],
-            "homework_url": "https://httpbin.org/status/200",
+            "homework_url": "https://github.com/existing/repo",
             "learning_in_public_links[]": [""],
             "time_spent_lectures": "",
             "time_spent_homework": "",
@@ -953,6 +965,42 @@ def test_submit_homework_with_all_fields_optional_empty(self):
         self.assertEqual(submission.problems_comments, "")
         self.assertEqual(submission.faq_contribution, "")
 
+    @mock.patch("requests.get")
+    def test_submit_homework_url_validation_404_error(self, mock_get):
+        mock_response = mock.Mock()
+        mock_response.status_code = 404
+        mock_get.return_value = mock_response
+
+        self.homework.homework_url_field = True
+        self.homework.save()
+
+        self.client.login(**credentials)
+
+        post_data = {
+            f"answer_{self.question1.id}": ["1"],
+            f"answer_{self.question2.id}": ["Some other text"],
+            f"answer_{self.question3.id}": ["1", "2", "4"],
+            f"answer_{self.question4.id}": ["3"],
+            f"answer_{self.question5.id}": ["3.141516"],
+            f"answer_{self.question6.id}": ["1", "2"],
+            "homework_url": "https://github.com/nonexistent/repo",
+        }
+
+        url = reverse(
+            "homework",
+            kwargs={
+                "course_slug": self.course.slug,
+                "homework_slug": self.homework.slug,
+            },
+        )
+
+        response = self.client.post(url, post_data)
+
+        # Should return form with errors due to 404
+        self.assertEqual(response.status_code, 200)
+        self.assertContains(response, "The submitted GitHub link")
+        self.assertContains(response, "does not exist")
+
     def test_submit_homework_learning_in_public_empty_and_duplicates(
         self,
     ):
@@ -970,9 +1018,10 @@ def test_submit_homework_learning_in_public_empty_and_duplicates(
             f"answer_{self.question5.id}": ["3.141516"],
             f"answer_{self.question6.id}": ["1", "2"],
             "learning_in_public_links[]": [
-                "https://httpbin.org/status/200",
-                "https://httpbin.org/status/200",
-                "https://github.com/DataTalksClub",
+                "https://test.org/totally-existing-url/1",
+                "https://test.org/totally-existing-url/1",
+                "https://test.org/totally-existing-url/2",
+                "https://test.org/totally-existing-url/3",
             ],
         }
 
@@ -994,8 +1043,9 @@ def test_submit_homework_learning_in_public_empty_and_duplicates(
         )
 
         expected_learning_in_public_links = [
-            "https://httpbin.org/status/200",
-            "https://github.com/DataTalksClub",
+            "https://test.org/totally-existing-url/1",
+            "https://test.org/totally-existing-url/2",
+            "https://test.org/totally-existing-url/3",
         ]
         self.assertEqual(
             submission.learning_in_public_links,

courses/tests/test_project_view.py

@@ -1,5 +1,6 @@
 import logging
 
+from unittest import mock
 from django.urls import reverse
 from django.test import TestCase, Client
 from django.utils import timezone
@@ -167,10 +168,15 @@ def test_project_detail_with_scored_project(self):
         # Check if the context has 'disabled' as True
         self.assertTrue(response.context["disabled"])
 
-    def test_project_submission_post_no_submissions(self):
+    @mock.patch("requests.get")
+    def test_project_submission_post_no_submissions(self, mock_get):
         """
         Test posting a project submission when there are no existing submissions.
         """
+        mock_response = mock.Mock()
+        mock_response.status_code = 200
+        mock_get.return_value = mock_response
+
         self.client.login(**credentials)
         url = reverse(
             "project", args=[self.course.slug, self.project.slug]
@@ -207,7 +213,12 @@ def test_project_submission_post_no_submissions(self):
             submission.faq_contribution, data["faq_contribution"]
         )
 
-    def test_project_submission_post_creates_enrollment(self):
+    @mock.patch("requests.get")
+    def test_project_submission_post_creates_enrollment(self, mock_get):
+        mock_response = mock.Mock()
+        mock_response.status_code = 200
+        mock_get.return_value = mock_response
+
         self.enrollment.delete()
 
         enrollments = Enrollment.objects.filter(
@@ -224,7 +235,7 @@ def test_project_submission_post_creates_enrollment(self):
         )
 
         data = {
-            "github_link": "https://httpbin.org/status/200",
+            "github_link": "https://github.com/existing/repo",
             "commit_id": "1234567",
             "time_spent": "2",
             "problems_comments": "Encountered an issue with...",
@@ -235,18 +246,23 @@ def test_project_submission_post_creates_enrollment(self):
 
         self.assertEqual(enrollments.count(), 1)
 
-    def test_project_submission_post_with_submissions(self):
+    @mock.patch("requests.get")
+    def test_project_submission_post_with_submissions(self, mock_get):
         """
         Test posting a project submission when there are existing submissions.
         """
+        mock_response = mock.Mock()
+        mock_response.status_code = 200
+        mock_get.return_value = mock_response
+
         self.client.login(**credentials)
 
         # Create an initial submission
         submission = ProjectSubmission.objects.create(
             project=self.project,
             student=self.user,
             enrollment=self.enrollment,
-            github_link="https://httpbin.org/status/200",
+            github_link="https://github.com/existing/repo",
             commit_id="123456a",
         )
 
@@ -255,7 +271,7 @@ def test_project_submission_post_with_submissions(self):
         )
 
         data = {
-            "github_link": "https://httpbin.org/status/200",
+            "github_link": "https://github.com/existing/repo",
             "commit_id": "123456e",
             "time_spent": "3",
             "problems_comments": "No issues encountered.",
@@ -293,7 +309,7 @@ def test_remove_project_submission(self):
             project=self.project,
             student=self.user,
             enrollment=self.enrollment,
-            github_link="https://httpbin.org/status/200",
+            github_link="https://github.com/existing/repo",
             commit_id="123456a",
         )
 
@@ -305,18 +321,17 @@ def test_remove_project_submission(self):
 
         self.assertEqual(count_sumissions, 1)
 
-
         url = reverse(
             "project", args=[self.course.slug, self.project.slug]
         )
 
         data = {
-            "github_link": "https://httpbin.org/status/200",
+            "github_link": "https://github.com/existing/repo",
             "commit_id": "123456e",
             "time_spent": "3",
             "problems_comments": "No issues encountered.",
             "faq_contribution": "Helped a peer with their problem.",
-            "action": "delete"
+            "action": "delete",
         }
 
         response = self.client.post(url, data)
@@ -330,7 +345,6 @@ def test_remove_project_submission(self):
 
         self.assertEqual(count_sumissions, 0)
 
-
     # this test requires a redesing of the project view
     # skipping for now
     # def test_submission_exist_post_with_error(self):
@@ -399,7 +413,7 @@ def test_project_submission_not_accepting_responses(self):
         )
 
         data = {
-            "github_link": "https://httpbin.org/status/200",
+            "github_link": "https://github.com/existing/repo",
             "commit_id": "1234567",
             "time_spent": "2",
             "problems_comments": "Encountered an issue with...",
@@ -417,11 +431,18 @@ def test_project_submission_not_accepting_responses(self):
 
         self.assertEqual(submissions.count(), 0)
 
-    def test_project_submission_post_invalid_link_no_submission(self):
+    @mock.patch("requests.get")
+    def test_project_submission_post_invalid_link_no_submission(
+        self, mock_get
+    ):
         """
         When the link is invalid and there's no submission yet,
         no submission is created
         """
+        mock_response = mock.Mock()
+        mock_response.status_code = 404
+        mock_get.return_value = mock_response
+
         self.client.login(**credentials)
         url = reverse(
             "project", args=[self.course.slug, self.project.slug]