Skip to content

Commit de1f481

Browse files
Address code review feedback: add null checks and radix to parseInt
Co-authored-by: alexeygrigorev <875246+alexeygrigorev@users.noreply.github.com>
1 parent 9e5934b commit de1f481

1 file changed

Lines changed: 9 additions & 4 deletions

File tree

cadmin/templates/cadmin/project_submission_edit.html

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -125,17 +125,22 @@ <h4>Overall Results</h4>
125125
function calculateTotal() {
126126
let total = 0;
127127
scoreFields.forEach(function(fieldId) {
128-
const value = parseInt(document.getElementById(fieldId).value) || 0;
129-
total += value;
128+
const field = document.getElementById(fieldId);
129+
if (field) {
130+
const value = parseInt(field.value, 10) || 0;
131+
total += value;
132+
}
130133
});
131134
document.getElementById('total_score').value = total;
132135
}
133136

134137
// Add event listeners to all score fields
135138
scoreFields.forEach(function(fieldId) {
136139
const field = document.getElementById(fieldId);
137-
field.addEventListener('input', calculateTotal);
138-
field.addEventListener('change', calculateTotal);
140+
if (field) {
141+
field.addEventListener('input', calculateTotal);
142+
field.addEventListener('change', calculateTotal);
143+
}
139144
});
140145
});
141146
</script>

0 commit comments

Comments
 (0)