Merge issue #172: cover public detail states with JavaScript disabled (#172)

Author: alexeygrigorev

core/accessibility_registry.py

@@ -173,6 +173,42 @@ def _state(
     ),
 )
 
+# The meaningful public read-only states that must render without client-side JavaScript.  Keep
+# route-contract states (the removed people catalogue and approved redirect) in the complete
+# JavaScript-enabled scenario only: they assert an HTTP contract rather than a rendered page.
+#
+# The Playwright fixture owns the source-backed surface/marker map.  Its policy check requires
+# this tuple to match that map exactly, so a stale/duplicated/unclassified registry ID fails before
+# a browser matrix can silently skip it.
+NO_JAVASCRIPT_PUBLIC_STATE_IDS = (
+    "public.home",
+    "public.blog-hub",
+    "public.podcast-hub",
+    "public.books-hub",
+    "public.events-hub",
+    "public.courses-hub",
+    "public.wiki-hub",
+    "public.docs-hub",
+    "public.faq-hub",
+    "public.slack",
+    "public.article-detail",
+    "public.podcast-transcript-media",
+    "public.book-detail",
+    "public.event-aggregate-speaker",
+    "public.person-detail",
+    "public.course-detail",
+    "public.wiki-detail",
+    "public.docs-nested",
+    "public.faq-anchor",
+    "public.wiki-results",
+    "public.wiki-zero-results",
+    "public.wiki-graph",
+    "public.wiki-special-pages",
+    "public.missing-media",
+    "public.empty-state",
+    "public.application-404",
+)
+
 # No exception is accepted by this implementation. Keeping the typed registry here makes any
 # future exception reviewable and forces all required ownership/expiry fields to be supplied.
 AXE_EXCEPTIONS: tuple[AxeException, ...] = ()

core/static/core/accessibility.css

@@ -6,6 +6,16 @@ body {
   overflow-wrap: anywhere;
 }
 
+/*
+ * Public detail artwork is rendered before the Tailwind runtime runs. Keep the
+ * source-backed media inside the readable article column when JavaScript is
+ * disabled (the utility classes still provide the richer JS-enabled styling).
+ */
+#main-content > #content > article > img {
+  height: auto;
+  max-width: 100%;
+}
+
 .faq-answer :is(code, pre) {
   overflow-wrap: anywhere;
   white-space: pre-wrap;

core/tests/test_accessibility.py

@@ -13,6 +13,7 @@
     AXE_EXCEPTIONS,
     BEHAVIOR_SCENARIOS,
     CRITICAL_STATES,
+    NO_JAVASCRIPT_PUBLIC_STATE_IDS,
     registry_fingerprint,
     template_readability_issues,
     template_surface,
@@ -65,6 +66,21 @@ def test_registry_identifiers_and_rendered_surfaces_are_fail_closed(self) -> Non
                     self.assertTrue(state.route_contract)
         self.assertRegex(registry_fingerprint(), r"^[0-9a-f]{64}$")
 
+    def test_no_javascript_public_policy_is_exactly_rendered_public_states(self) -> None:
+        self.assertEqual(len(NO_JAVASCRIPT_PUBLIC_STATE_IDS), 26)
+        self.assertEqual(
+            len(NO_JAVASCRIPT_PUBLIC_STATE_IDS),
+            len(set(NO_JAVASCRIPT_PUBLIC_STATE_IDS)),
+        )
+        states = {state.identifier: state for state in CRITICAL_STATES}
+        for identifier in NO_JAVASCRIPT_PUBLIC_STATE_IDS:
+            with self.subTest(state=identifier):
+                state = states[identifier]
+                self.assertEqual(state.group, "public")
+                self.assertEqual(state.behavior_test, "public-current-states")
+                self.assertIsNotNone(state.axe_surface)
+                self.assertFalse(state.route_contract)
+
     def test_every_authored_product_template_has_one_surface_owner(self) -> None:
         root = Path(settings.BASE_DIR)
         candidates: set[Path] = set()