fix: flush Ogg pages immediately after each Opus packet to ensure data flow to listeners

Datanoise · Datanoise · commit 4d8822ec9fe0 · 2026-02-20T17:42:57.000+01:00
diff --git a/relay/transcode.go b/relay/transcode.go
@@ -197,6 +197,8 @@ func (tm *TranscoderManager) encodeMP3(ctx context.Context, inst *TranscoderInst
 			if err != nil {
 				return
 			}
+			// Note: Shine MP3 doesn't have a flush but we should ensure 
+			// our writer is called.
 			atomic.AddInt64(&inst.FramesProcessed, 1)
 		}
 	}
@@ -289,6 +291,7 @@ func (tm *TranscoderManager) encodeOpus(ctx context.Context, inst *TranscoderIns
 			if err := pw.WritePacket(opusPacket[:en], granulePos, false, false); err != nil {
 				return
 			}
+			pw.Flush()
 			
 			sentCount++
 			atomic.AddInt64(&inst.FramesProcessed, 1)

Original file line number	Diff line number	Diff line change
`@@ -197,6 +197,8 @@ func (tm TranscoderManager) encodeMP3(ctx context.Context, inst TranscoderInst`
`197`	`197`	`if err != nil {`
`198`	`198`	`return`
`199`	`199`	`}`
	`200`	`+ // Note: Shine MP3 doesn't have a flush but we should ensure`
	`201`	`+ // our writer is called.`
`200`	`202`	`atomic.AddInt64(&inst.FramesProcessed, 1)`
`201`	`203`	`}`
`202`	`204`	`}`
`@@ -289,6 +291,7 @@ func (tm TranscoderManager) encodeOpus(ctx context.Context, inst TranscoderIns`
`289`	`291`	`if err := pw.WritePacket(opusPacket[:en], granulePos, false, false); err != nil {`
`290`	`292`	`return`
`291`	`293`	`}`
	`294`	`+ pw.Flush()`
`292`	`295`
`293`	`296`	`sentCount++`
`294`	`297`	`atomic.AddInt64(&inst.FramesProcessed, 1)`