fix: disable ICY metadata for Ogg streams to prevent demuxer corruption and CRC errors

Author: Datanoise

relay/relay.go

@@ -244,6 +244,12 @@ func (r *Relay) GetStream(mount string) (*Stream, bool) {
 	return s, ok
 }
 
+// IsOgg returns true if the stream is Ogg-based (Ogg/Vorbis, Ogg/Opus, etc)
+func (s *Stream) IsOgg() bool {
+	ct := strings.ToLower(s.ContentType)
+	return strings.Contains(ct, "ogg") || strings.Contains(ct, "opus")
+}
+
 // Close closes all listeners on the stream
 func (s *Stream) Close() {
 	s.mu.Lock()

server/server.go

@@ -846,14 +846,6 @@ func (s *Server) handleListener(w http.ResponseWriter, r *http.Request) {
 		w.Header().Set("X-Accel-Buffering", "no")
 	}
 
-	// ICY Metadata negotiation
-	metaint := 0
-	if r.Header.Get("Icy-MetaData") == "1" {
-		metaint = 16000 // Standard interval
-		w.Header().Set("icy-metaint", "16000")
-		w.Header().Set("icy-name", s.Config.PageTitle)
-	}
-
 	flusher, _ := w.(http.Flusher)
 	id := r.RemoteAddr + "-" + fmt.Sprintf("%d", time.Now().UnixNano())
 	logrus.WithFields(logrus.Fields{"mount": mount, "ip": r.RemoteAddr, "ua": r.Header.Get("User-Agent")}).Info("Listener connected")
@@ -889,6 +881,16 @@ func (s *Server) handleListener(w http.ResponseWriter, r *http.Request) {
 			return
 		}
 
+		// ICY Metadata negotiation
+		metaint := 0
+		// Ogg/Opus handles its own metadata. Injecting ICY metadata into an Ogg 
+		// stream corrupts the framing and causes CRC errors.
+		if r.Header.Get("Icy-MetaData") == "1" && !stream.IsOgg() {
+			metaint = 16000 // Standard interval
+			w.Header().Set("icy-metaint", "16000")
+			w.Header().Set("icy-name", s.Config.PageTitle)
+		}
+
 		if s.Config.MaxListeners > 0 && stream.ListenersCount() >= s.Config.MaxListeners {
 			http.Error(w, "Server Full", http.StatusServiceUnavailable)
 			return