Skip to content

Commit c6ad7cd

Browse files
author
tim
committed
Address PR feedback: simplify Hessen coordinate extraction
- Update type annotation to tuple[float, float] | tuple[None, None] - Simplify README geolocation description (remove concrete numbers) - Remove superfluous 'or None' from normalize() method
1 parent 1bc9069 commit c6ad7cd

1 file changed

Lines changed: 11 additions & 11 deletions

File tree

jedeschule/spiders/hessen.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ def parse_list(self, response):
5353
for school in schools:
5454
yield scrapy.Request(school, callback=self.parse_details)
5555

56-
def _extract_coords_from_osm_url(self, url: str) -> tuple[float | None, float | None]:
56+
def _extract_coords_from_osm_url(self, url: str) -> tuple[float, float] | tuple[None, None]:
5757
"""Extract coordinates from OpenStreetMap iframe URL marker parameter"""
5858
qs = parse_qs(urlparse(url).query)
5959

@@ -128,15 +128,15 @@ def parse_details(self, response):
128128
def normalize(item: Item) -> School:
129129
"""Transform raw scraped data into standardized School model"""
130130
return School(
131-
name=item.get("name") or None,
132-
phone=item.get("telefon") or None,
133-
fax=item.get("fax") or None,
134-
website=item.get("homepage") or None,
135-
address=item.get("straße") or None,
136-
city=item.get("ort") or None,
137-
zip=item.get("plz") or None,
138-
school_type=item.get("schultyp") or None,
131+
name=item.get("name"),
132+
phone=item.get("telefon"),
133+
fax=item.get("fax"),
134+
website=item.get("homepage"),
135+
address=item.get("straße"),
136+
city=item.get("ort"),
137+
zip=item.get("plz"),
138+
school_type=item.get("schultyp"),
139139
id="HE-{}".format(item.get("id")), # Prefix with state code
140-
latitude=item.get("latitude") or None,
141-
longitude=item.get("longitude") or None,
140+
latitude=item.get("latitude"),
141+
longitude=item.get("longitude"),
142142
)

0 commit comments

Comments
 (0)