Loosen types, better error handling when IDN unavailable

Author: DaveRandom

src/Records/Types/Anything.php

@@ -33,8 +33,10 @@ class Anything extends Type
      * @param string $value The new value
      * @throws \UnexpectedValueException When the supplied value is outside the valid length range 0 - 65535
      */
-    public function setValue(string $value)
+    public function setValue($value)
     {
+        $value = (string)$value;
+
         if (\strlen($value) > 65535) {
             throw new \UnexpectedValueException('Untyped string length must be in the range 0 - 65535');
         }

src/Records/Types/BitMap.php

@@ -32,9 +32,9 @@ class BitMap extends Type
      *
      * @param string $value The new value
      */
-    public function setValue(string $value)
+    public function setValue($value)
     {
-        $this->value = $value;
+        $this->value = (string)$value;
     }
 
     /**

src/Records/Types/Char.php

@@ -34,7 +34,7 @@ class Char extends Type
      * @throws \UnderflowException When the supplied value is less than 0
      * @throws \OverflowException When the supplied value is greater than 255
      */
-    public function setValue(string $value)
+    public function setValue($value)
     {
         $value = (int) $value;
 

src/Records/Types/CharacterString.php

@@ -33,8 +33,10 @@ class CharacterString extends Type
      * @param string $value The new value
      * @throws \UnexpectedValueException When the supplied value is outside the valid length range 0 - 255
      */
-    public function setValue(string $value)
+    public function setValue($value)
     {
+        $value = (string)$value;
+
         if (\strlen($value) > 255) {
             throw new \UnexpectedValueException('Character string length must be in the range 0 - 255');
         }

src/Records/Types/DomainName.php

@@ -51,12 +51,21 @@ public function __construct($value = null)
             self::$labelPreProcessor = \function_exists('idn_to_ascii')
                 ? static function($label) {
                       if (false === $result = \idn_to_ascii($label, 0, INTL_IDNA_VARIANT_UTS46)) {
-                          throw new \InvalidArgumentException('Label ' . $label . ' could not be processed for IDN');
+                          throw new \InvalidArgumentException("Label '{$label}' could not be processed for IDN");
                       }
 
                       return $result;
                   }
-                : 'strtolower';
+                : static function($label) {
+                      if (\preg_match('/[\x80-\xff]/', $label)) {
+                          throw new \RuntimeException(
+                              "Label '{$label}' contains non-ASCII characters and IDN support is not available."
+                              . " Verify that ext/intl is installed for IDN support."
+                          );
+                      }
+
+                      return \strtolower($label);
+                  };
         }
 
         if (\is_array($value)) {
@@ -72,9 +81,9 @@ public function __construct($value = null)
      * @param string $value The new value
      * @throws \UnexpectedValueException When the supplied value is not a valid domain name
      */
-    public function setValue(string $value)
+    public function setValue($value)
     {
-        $this->setLabels(\explode('.', $value));
+        $this->setLabels(\explode('.', (string)$value));
     }
 
     /**

src/Records/Types/IPv4Address.php

@@ -53,9 +53,9 @@ public function __construct($value = null)
      * @param string $value The new value
      * @throws \UnexpectedValueException When the supplied value is outside the valid length range 0 - 65535
      */
-    public function setValue(string $value)
+    public function setValue($value)
     {
-        $this->setOctets(\explode('.', $value));
+        $this->setOctets(\explode('.', (string)$value));
     }
 
     /**

src/Records/Types/IPv6Address.php

@@ -104,9 +104,9 @@ public function __construct($value = null)
      * @param string $value The new value
      * @throws \UnexpectedValueException When the supplied value is outside the valid length range 0 - 65535
      */
-    public function setValue(string $value)
+    public function setValue($value)
     {
-        $shorts = \explode(':', $value);
+        $shorts = \explode(':', (string)$value);
 
         $count = \count($shorts);
         if ($count < 3 || $count > 8) {

src/Records/Types/Long.php

@@ -34,9 +34,9 @@ class Long extends Type
      * @throws \UnderflowException When the supplied value is less than 0
      * @throws \OverflowException When the supplied value is greater than 4294967296
      */
-    public function setValue(string $value)
+    public function setValue($value)
     {
-        $value = (int) $value;
+        $value = (int)$value;
 
         if ($value < 0) {
             throw new \UnderflowException('Long integer value must be in the range 0 - 4294967296');

src/Records/Types/Short.php

@@ -34,9 +34,9 @@ class Short extends Type
      * @throws \UnderflowException When the supplied value is less than 0
      * @throws \OverflowException When the supplied value is greater than 65535
      */
-    public function setValue(string $value)
+    public function setValue($value)
     {
-        $value = (int) $value;
+        $value = (int)$value;
 
         if ($value < 0) {
             throw new \UnderflowException('Short integer value must be in the range 0 - 65535');

src/Records/Types/Type.php

@@ -66,5 +66,5 @@ public function getValue()
      * @param string $value The new value
      * @throws \RuntimeException When the supplied value is invalid
      */
-    abstract public function setValue(string $value);
+    abstract public function setValue($value);
 }