Add $allowTrailingData to decoder

Author: DaveRandom

src/Decoder/Decoder.php

@@ -71,6 +71,11 @@ class Decoder
      */
     private $decodingContextFactory;
 
+    /**
+     * @var bool
+     */
+    private $allowTrailingData;
+
     /**
      * Constructor
      *
@@ -80,21 +85,24 @@ class Decoder
      * @param \LibDNS\Records\ResourceBuilder $resourceBuilder
      * @param \LibDNS\Records\Types\TypeBuilder $typeBuilder
      * @param \LibDNS\Decoder\DecodingContextFactory $decodingContextFactory
+     * @param bool $allowTrailingData
      */
     public function __construct(
         PacketFactory $packetFactory,
         MessageFactory $messageFactory,
         QuestionFactory $questionFactory,
         ResourceBuilder $resourceBuilder,
         TypeBuilder $typeBuilder,
-        DecodingContextFactory $decodingContextFactory
+        DecodingContextFactory $decodingContextFactory,
+        $allowTrailingData = false
     ) {
         $this->packetFactory = $packetFactory;
         $this->messageFactory = $messageFactory;
         $this->questionFactory = $questionFactory;
         $this->resourceBuilder = $resourceBuilder;
         $this->typeBuilder = $typeBuilder;
         $this->decodingContextFactory = $decodingContextFactory;
+        $this->allowTrailingData = $allowTrailingData;
     }
 
     /**
@@ -476,7 +484,7 @@ public function decode($data)
             $additionalRecords->add($this->decodeResourceRecord($decodingContext));
         }
 
-        if ($packet->getBytesRemaining() !== 0) {
+        if (!$this->allowTrailingData && $packet->getBytesRemaining() !== 0) {
             throw new \UnexpectedValueException('Decode error: Unexpected data at end of packet');
         }
 

src/Decoder/DecoderFactory.php

@@ -40,9 +40,10 @@ class DecoderFactory
      * Create a new Decoder object
      *
      * @param \LibDNS\Records\TypeDefinitions\TypeDefinitionManager $typeDefinitionManager
-     * @return \LibDNS\Decoder\Decoder
+     * @param bool $allowTrailingData
+     * @return Decoder
      */
-    public function create(TypeDefinitionManager $typeDefinitionManager = null)
+    public function create(TypeDefinitionManager $typeDefinitionManager = null, $allowTrailingData = false)
     {
         $typeBuilder = new TypeBuilder(new TypeFactory);
 
@@ -62,7 +63,8 @@ public function create(TypeDefinitionManager $typeDefinitionManager = null)
                 )
             ),
             $typeBuilder,
-            new DecodingContextFactory
+            new DecodingContextFactory,
+            $allowTrailingData
         );
     }
 }