Merge pull request #30 from alexandre-daubois/explicit-nullable-type

Add explicit nullable type where required

Author: kelunik

composer.json

@@ -4,7 +4,7 @@
     "license": "MIT",
     "keywords": ["dns"],
     "require": {
-        "php": ">=7.0",
+        "php": ">=7.1",
         "ext-ctype": "*"
     },
     "autoload": {

src/Decoder/DecoderFactory.php

@@ -43,7 +43,7 @@ class DecoderFactory
      * @param bool $allowTrailingData
      * @return Decoder
      */
-    public function create(TypeDefinitionManager $typeDefinitionManager = null, bool $allowTrailingData = true): Decoder
+    public function create(?TypeDefinitionManager $typeDefinitionManager = null, bool $allowTrailingData = true): Decoder
     {
         $typeBuilder = new TypeBuilder(new TypeFactory);
 

src/Encoder/EncodingContext.php

@@ -95,7 +95,7 @@ public function useCompression(): bool
      * @param bool $truncate
      * @return bool
      */
-    public function isTruncated(bool $truncate = null): bool
+    public function isTruncated(?bool $truncate = null): bool
     {
         $result = $this->truncate;
 

src/Messages/Message.php

@@ -93,7 +93,7 @@ class Message
      * @param int $type Value of the message type field
      * @throws \RangeException When the supplied message type is outside the valid range 0 - 1
      */
-    public function __construct(RecordCollectionFactory $recordCollectionFactory, int $type = null)
+    public function __construct(RecordCollectionFactory $recordCollectionFactory, ?int $type = null)
     {
         $this->questionRecords = $recordCollectionFactory->create(RecordTypes::QUESTION);
         $this->answerRecords = $recordCollectionFactory->create(RecordTypes::RESOURCE);
@@ -186,7 +186,7 @@ public function setOpCode(int $opCode)
      * @param bool $newValue The new value
      * @return bool The old value
      */
-    public function isAuthoritative(bool $newValue = null): bool
+    public function isAuthoritative(?bool $newValue = null): bool
     {
         $result = $this->authoritative;
 
@@ -203,7 +203,7 @@ public function isAuthoritative(bool $newValue = null): bool
      * @param bool $newValue The new value
      * @return bool The old value
      */
-    public function isTruncated(bool $newValue = null): bool
+    public function isTruncated(?bool $newValue = null): bool
     {
         $result = $this->truncated;
 
@@ -220,7 +220,7 @@ public function isTruncated(bool $newValue = null): bool
      * @param bool $newValue The new value
      * @return bool The old value
      */
-    public function isRecursionDesired(bool $newValue = null): bool
+    public function isRecursionDesired(?bool $newValue = null): bool
     {
         $result = $this->recursionDesired;
 
@@ -237,7 +237,7 @@ public function isRecursionDesired(bool $newValue = null): bool
      * @param bool $newValue The new value
      * @return bool The old value
      */
-    public function isRecursionAvailable(bool $newValue = null): bool
+    public function isRecursionAvailable(?bool $newValue = null): bool
     {
         $result = $this->recursionAvailable;
 

src/Messages/MessageFactory.php

@@ -30,7 +30,7 @@ class MessageFactory
      * @param int $type Value of the message type field
      * @return \LibDNS\Messages\Message
      */
-    public function create(int $type = null): Message
+    public function create(?int $type = null): Message
     {
         return new Message(new RecordCollectionFactory, $type);
     }

src/Packets/Packet.php

@@ -55,7 +55,7 @@ public function __construct(string $data = '')
      * @return string
      * @throws \OutOfBoundsException When the pointer position is invalid or the supplied length is negative
      */
-    public function read(int $length = null): string
+    public function read(?int $length = null): string
     {
         if ($this->pointer > $this->length) {
             throw new \OutOfBoundsException('Pointer position invalid');

src/Records/ResourceBuilderFactory.php

@@ -34,7 +34,7 @@ class ResourceBuilderFactory
      * @param \LibDNS\Records\TypeDefinitions\TypeDefinitionManager $typeDefinitionManager
      * @return \LibDNS\Records\ResourceBuilder
      */
-    public function create(TypeDefinitionManager $typeDefinitionManager = null): ResourceBuilder
+    public function create(?TypeDefinitionManager $typeDefinitionManager = null): ResourceBuilder
     {
         return new ResourceBuilder(
             new ResourceFactory,

src/Records/Types/BitMap.php

@@ -44,7 +44,7 @@ public function setValue($value)
      * @param bool $newValue The new value
      * @return bool The old value
      */
-    public function isBitSet(int $index, bool $newValue = null): bool
+    public function isBitSet(int $index, ?bool $newValue = null): bool
     {
         $charIndex = (int)($index / 8);
         $bitMask = 0b10000000 >> ($index % 8);

src/Records/Types/Type.php

@@ -33,7 +33,7 @@ abstract class Type
      * @param string $value Internal value
      * @throws \RuntimeException When the supplied value is invalid
      */
-    public function __construct(string $value = null)
+    public function __construct(?string $value = null)
     {
         if (isset($value)) {
             $this->setValue($value);

src/Records/Types/TypeFactory.php

@@ -28,7 +28,7 @@ class TypeFactory
      * @param string $value
      * @return \LibDNS\Records\Types\Anything
      */
-    public function createAnything(string $value = null)
+    public function createAnything(?string $value = null)
     {
         return new Anything($value);
     }
@@ -39,7 +39,7 @@ public function createAnything(string $value = null)
      * @param string $value
      * @return \LibDNS\Records\Types\BitMap
      */
-    public function createBitMap(string $value = null)
+    public function createBitMap(?string $value = null)
     {
         return new BitMap($value);
     }
@@ -50,7 +50,7 @@ public function createBitMap(string $value = null)
      * @param int $value
      * @return \LibDNS\Records\Types\Char
      */
-    public function createChar(int $value = null)
+    public function createChar(?int $value = null)
     {
         return new Char((string)$value);
     }
@@ -61,7 +61,7 @@ public function createChar(int $value = null)
      * @param string $value
      * @return \LibDNS\Records\Types\CharacterString
      */
-    public function createCharacterString(string $value = null)
+    public function createCharacterString(?string $value = null)
     {
         return new CharacterString($value);
     }
@@ -105,7 +105,7 @@ public function createIPv6Address($value = null)
      * @param int $value
      * @return \LibDNS\Records\Types\Long
      */
-    public function createLong(int $value = null)
+    public function createLong(?int $value = null)
     {
         return new Long((string)$value);
     }
@@ -116,7 +116,7 @@ public function createLong(int $value = null)
      * @param int $value
      * @return \LibDNS\Records\Types\Short
      */
-    public function createShort(int $value = null)
+    public function createShort(?int $value = null)
     {
         return new Short((string)$value);
     }