chore: remove the agent feature in favor of SSH (#365)

* chore: remove the agent feature in favor of SSH

The remote-agent mode (DATABASEMENT_URL + agent:run + on-server polling
agent) never landed cleanly in practice. SSH tunnels already cover the
"reach a private/firewalled database" use case, so the second pathway
adds maintenance cost without unique value.

Removes:
- agent:run command, AgentController, agent API routes & middleware
- Agent/AgentJob models, factories, policy, query, payload builder
- Agent CRUD Livewire pages, layout menu entry, agent_id form field
- DATABASEMENT_URL branches in config/{database,cache,queue,session}.php
- DTO toPayload()/fromPayload() (only consumers were the agent)

The jobs:recover-stuck command keeps its backup-job recovery half
(handles queue worker crashes) — only the agent-lease half is dropped.

Schema cleanup is forward-only: existing migrations are left untouched
(production has already run them). A new drop migration removes the
agents tables and database_servers.agent_id with hasTable/hasColumn
guards so fresh installs and existing prod converge on the same state.

* refactor: simplify the files touched by the agent removal

Light cleanup pass on the three files most affected by the previous
commit:

- TriggerBackupAction: drop the stale @throws ValidationException now
  that the method no longer dispatches to an agent or re-throws.
- SetCurrentOrganization::handle: collapse the deeply-nested
  `if ($user instanceof User)` block into an early return — the
  middleware now only has one branch worth nesting for.
- SaveDatabaseServerRequest: extract the duplicated $backupsEnabled
  resolution from rules() and withValidator() into a private helper.

Author: David-Crty

CLAUDE.md

@@ -111,19 +111,6 @@ The Docker setup provides:
 
 **Queue Worker**: The queue service automatically starts with `make start` and processes jobs from the `backups` queue. It restarts automatically on failure and respects a max of 1000 jobs before auto-restarting (prevents memory leaks).
 
-## Agent Mode
-
-When `DATABASEMENT_URL` is set, the app runs as a remote agent — it only executes the `agent:run` CLI command (polls an API and runs `BackupTask`). It never uses the app's own database.
-
-Config files check `env('DATABASEMENT_URL')` to swap database-dependent drivers for in-memory/no-op alternatives:
-
-- **Database**: `agent` connection (SQLite `:memory:`)
-- **Cache**: `array` driver
-- **Queue**: `sync` driver
-- **Session**: `array` driver
-
-This means agent mode requires zero database configuration.
-
 ## Architecture
 
 ### Application Structure

app/Console/Commands/AgentRunCommand.php

@@ -3,7 +3,6 @@
 namespace App\Console\Commands;
 
 use App\Facades\AppConfig;
-use App\Models\AgentJob;
 use App\Models\BackupJob;
 use Illuminate\Console\Command;
 use RuntimeException;
@@ -15,71 +14,9 @@ class RecoverStuckJobsCommand extends Command
 
     protected $signature = 'jobs:recover-stuck';
 
-    protected $description = 'Recover stuck jobs (expired agent leases and timed-out backup jobs)';
+    protected $description = 'Recover backup jobs stuck in running/pending state beyond their timeout';
 
     public function handle(): int
-    {
-        $agentResult = $this->recoverAgentJobs();
-        $backupResult = $this->recoverBackupJobs();
-
-        if (! $agentResult && ! $backupResult) {
-            $this->info('No stuck jobs found.');
-        }
-
-        return self::SUCCESS;
-    }
-
-    /**
-     * Recover expired agent job leases (reset or fail stale jobs).
-     */
-    private function recoverAgentJobs(): bool
-    {
-        $expiredJobs = AgentJob::query()
-            ->with(['snapshot.job'])
-            ->whereIn('status', [AgentJob::STATUS_CLAIMED, AgentJob::STATUS_RUNNING])
-            ->where('lease_expires_at', '<', now())
-            ->get();
-
-        if ($expiredJobs->isEmpty()) {
-            return false;
-        }
-
-        $resetCount = 0;
-        $failedCount = 0;
-
-        foreach ($expiredJobs as $job) {
-            if ($job->attempts < $job->max_attempts) {
-                $job->update([
-                    'status' => AgentJob::STATUS_PENDING,
-                    'agent_id' => null,
-                    'lease_expires_at' => null,
-                ]);
-                $resetCount++;
-            } else {
-                $errorMessage = "Max attempts ({$job->max_attempts}) exceeded with expired lease.";
-                $job->markFailed($errorMessage);
-
-                $job->snapshot->job->markFailed(
-                    new RuntimeException("Agent job failed: {$errorMessage}")
-                );
-                $failedCount++;
-            }
-        }
-
-        $this->info("Agent jobs: recovered {$resetCount}, failed {$failedCount}.");
-
-        return true;
-    }
-
-    /**
-     * Recover backup jobs stuck in running/pending state beyond their timeout.
-     *
-     * Running jobs are compared against started_at, while pending jobs (which
-     * were never picked up) are compared against created_at. A grace period is
-     * added on top of the configured timeout to avoid killing jobs that are
-     * still legitimately processing.
-     */
-    private function recoverBackupJobs(): bool
     {
         $timeout = AppConfig::get('backup.job_timeout') + self::GRACE_PERIOD_SECONDS;
         $cutoff = now()->subSeconds($timeout);
@@ -98,7 +35,9 @@ private function recoverBackupJobs(): bool
             ->get();
 
         if ($stuckJobs->isEmpty()) {
-            return false;
+            $this->info('No stuck jobs found.');
+
+            return self::SUCCESS;
         }
 
         foreach ($stuckJobs as $job) {
@@ -109,6 +48,6 @@ private function recoverBackupJobs(): bool
 
         $this->info("Backup jobs: failed {$stuckJobs->count()} stuck job(s).");
 
-        return true;
+        return self::SUCCESS;
     }
 }

app/Console/Commands/RecoverStuckJobsCommand.php

@@ -3,10 +3,8 @@
 namespace App\Console\Commands;
 
 use App\Jobs\ProcessBackupJob;
-use App\Models\AgentJob;
 use App\Models\Backup;
 use App\Models\BackupSchedule;
-use App\Services\Agent\AgentJobPayloadBuilder;
 use App\Services\Backup\BackupJobFactory;
 use Illuminate\Console\Command;
 use Illuminate\Support\Facades\Log;
@@ -17,7 +15,7 @@ class RunScheduledBackups extends Command
 
     protected $description = 'Run scheduled backups for a given backup schedule';
 
-    public function handle(BackupJobFactory $backupJobFactory, AgentJobPayloadBuilder $payloadBuilder): int
+    public function handle(BackupJobFactory $backupJobFactory): int
     {
         $scheduleId = $this->argument('schedule');
 
@@ -46,7 +44,7 @@ public function handle(BackupJobFactory $backupJobFactory, AgentJobPayloadBuilde
 
         foreach ($backups as $backup) {
             try {
-                $this->dispatch($backup, $backupJobFactory, $payloadBuilder);
+                $this->dispatch($backup, $backupJobFactory);
             } catch (\Throwable $e) {
                 $failedCount++;
                 Log::error("Failed to dispatch backup job for server [{$backup->databaseServer->name} / {$backup->getDisplayLabel()}]", [
@@ -64,7 +62,7 @@ public function handle(BackupJobFactory $backupJobFactory, AgentJobPayloadBuilde
         return self::SUCCESS;
     }
 
-    private function dispatch(Backup $backup, BackupJobFactory $backupJobFactory, AgentJobPayloadBuilder $payloadBuilder): void
+    private function dispatch(Backup $backup, BackupJobFactory $backupJobFactory): void
     {
         $server = $backup->databaseServer;
 
@@ -73,52 +71,12 @@ private function dispatch(Backup $backup, BackupJobFactory $backupJobFactory, Ag
             method: 'scheduled',
         );
 
-        // Agent-backed servers with all/pattern mode return empty snapshots —
-        // dispatch a discovery job so the agent can list databases first.
-        if (empty($snapshots) && $server->agent_id) {
-            $hasInflightDiscovery = AgentJob::query()
-                ->where('database_server_id', $server->id)
-                ->where('type', AgentJob::TYPE_DISCOVER)
-                ->whereIn('status', [AgentJob::STATUS_PENDING, AgentJob::STATUS_CLAIMED, AgentJob::STATUS_RUNNING])
-                ->get()
-                ->contains(fn (AgentJob $job) => ($job->payload['backup_id'] ?? null) === $backup->id);
-
-            if ($hasInflightDiscovery) {
-                $this->line("  → Skipped discovery for: {$server->name} [{$backup->getDisplayLabel()}] (already in-flight)");
-
-                return;
-            }
-
-            AgentJob::create([
-                'type' => AgentJob::TYPE_DISCOVER,
-                'database_server_id' => $server->id,
-                'snapshot_id' => null,
-                'status' => AgentJob::STATUS_PENDING,
-                'payload' => $payloadBuilder->buildDiscovery($backup, 'scheduled', null),
-            ]);
-
-            $this->line("  → Dispatched discovery for: {$server->name} [{$backup->getDisplayLabel()}] via agent");
-
-            return;
-        }
-
         foreach ($snapshots as $snapshot) {
-            if ($server->agent_id) {
-                AgentJob::create([
-                    'type' => AgentJob::TYPE_BACKUP,
-                    'database_server_id' => $server->id,
-                    'snapshot_id' => $snapshot->id,
-                    'status' => AgentJob::STATUS_PENDING,
-                    'payload' => $payloadBuilder->build($snapshot),
-                ]);
-            } else {
-                ProcessBackupJob::dispatch($snapshot->id);
-            }
+            ProcessBackupJob::dispatch($snapshot->id);
         }
 
         $count = count($snapshots);
-        $via = $server->agent_id ? 'agent' : 'queue';
         $dbInfo = $count === 1 ? '1 database' : "{$count} databases";
-        $this->line("  → Dispatched backup for: {$server->name} [{$backup->getDisplayLabel()}] ({$dbInfo}) via {$via}");
+        $this->line("  → Dispatched backup for: {$server->name} [{$backup->getDisplayLabel()}] ({$dbInfo})");
     }
 }