Added ability to specify spdlog logging level: KasperskyLab#157

Author: DavidIkov

examples/mnist-learn/main.cpp

@@ -19,6 +19,8 @@
  * limitations under the License.
  */
 
+#include <spdlog/spdlog.h>
+
 #include <iostream>
 
 #include "dataset.h"
@@ -67,6 +69,8 @@ int main(int argc, char** argv)
     if (!model_desc_opt.has_value()) return EXIT_FAILURE;
     const ModelDescription& model_desc = model_desc_opt.value();
 
+    spdlog::set_level(static_cast<spdlog::level::level_enum>(model_desc.spdlog_level_));
+
     std::cout << "Starting model:\n" << model_desc << std::endl;
 
     // Starting model according to selected type.

examples/mnist-learn/model_desc.cpp

@@ -21,6 +21,8 @@
 
 #include "model_desc.h"
 
+#include <spdlog/spdlog.h>
+
 std::ostream& operator<<(std::ostream& stream, ModelDescription const& desc)
 {
     stream << "Model type: ";
@@ -55,5 +57,9 @@ std::ostream& operator<<(std::ostream& stream, ModelDescription const& desc)
     else
         stream << "Model saving path: " << desc.model_saving_path_ << "\n";
 
+    stream << "Spdlog logging level: "
+           << spdlog::level::to_string_view(static_cast<spdlog::level::level_enum>(desc.spdlog_level_)).begin() << "\n";
+
+
     return stream;
 }

examples/mnist-learn/model_desc.h

@@ -61,6 +61,10 @@ struct ModelDescription
 
     /// Path to folder for saving trained model in sonata format.
     std::filesystem::path model_saving_path_;
+
+    /// Spdlog logging level.
+    // cppcheck-suppress unusedStructMember
+    int spdlog_level_;
 };
 
 

examples/mnist-learn/parse_arguments.cpp

@@ -21,6 +21,8 @@
 
 #include "parse_arguments.h"
 
+#include <spdlog/spdlog.h>
+
 #include <iostream>
 #include <string>
 
@@ -42,7 +44,8 @@ std::optional<ModelDescription> parse_arguments(int argc, char** argv)
         "log_path", po::value<std::string>()->default_value(""),
         "path for putting logs. if no path is specified, no logs will be produced.")(
         "model_path", po::value<std::string>()->default_value(""),
-        "path for saving trained model. if no path is specified, model wont be saved.");
+        "path for saving trained model. if no path is specified, model wont be saved.")(
+        "spdlog_level", po::value<std::string>()->default_value("info"), "spdlog logging level.");
 
     po::variables_map vm;
     po::store(po::parse_command_line(argc, argv, desc), vm);
@@ -154,5 +157,22 @@ std::optional<ModelDescription> parse_arguments(int argc, char** argv)
         model_desc.model_saving_path_ = "";
     }
 
+    if (vm.count("spdlog_level"))
+    {
+        model_desc.spdlog_level_ = spdlog::level::from_str(vm["spdlog_level"].as<std::string>());
+        if (model_desc.spdlog_level_ == spdlog::level::off)
+        {
+            std::cout << "Spdlog logging level is incorrect." << std::endl;
+            std::cout << desc << std::endl;
+            return std::nullopt;
+        }
+    }
+    else
+    {
+        std::cout << "Spdlog logging level not specified." << std::endl;
+        std::cout << desc << std::endl;
+        return std::nullopt;
+    }
+
     return model_desc;
 }

knp/core-library/impl/backend.cpp

@@ -31,9 +31,6 @@ namespace knp::core
 Backend::Backend()
     : message_bus_{knp::core::MessageBus::construct_bus()}, message_endpoint_(message_bus_->create_endpoint())
 {
-#if (!defined(NDEBUG))
-    spdlog::set_level(spdlog::level::trace);
-#endif
 }