Got rid of def.h files by moving some shared stuff into interface_fwd files: KasperskyLab#121

Author: DavidIkov

knp/backends/cpu/cpu-library/include/knp/backends/cpu-library/impl/populations/altai/impl.h

@@ -19,6 +19,7 @@
  */
 #pragma once
 
+#include <knp/backends/cpu-library/impl/populations/interface_fwd.h>
 #include <knp/core/population.h>
 
 #include <limits>

knp/backends/cpu/cpu-library/include/knp/backends/cpu-library/impl/populations/altai/interface.h

@@ -19,9 +19,6 @@
  */
 #pragma once
 
-// This include does not work at the end of the day. But its here so code analyzer will work properly.
-#include <knp/backends/cpu-library/impl/populations/interface_fwd.h>
-
 #include <vector>
 
 #include "impl.h"

knp/backends/cpu/cpu-library/include/knp/backends/cpu-library/impl/populations/blifat/impl.h

@@ -19,6 +19,8 @@
  */
 #pragma once
 
+#include <knp/backends/cpu-library/impl/populations/interface_fwd.h>
+
 #include <limits>
 
 #include "stdp.h"

knp/backends/cpu/cpu-library/include/knp/backends/cpu-library/impl/populations/blifat/interface.h

@@ -19,9 +19,6 @@
  */
 #pragma once
 
-// This include does not work at the end of the day. But its here so code analyzer will work properly.
-#include <knp/backends/cpu-library/impl/populations/interface_fwd.h>
-
 #include <vector>
 
 #include "impl.h"

knp/backends/cpu/cpu-library/include/knp/backends/cpu-library/impl/projections/delta/impl.h

@@ -19,7 +19,7 @@
  */
 #pragma once
 
-#include <knp/backends/cpu-library/impl/projections/shared/def.h>
+#include <knp/backends/cpu-library/impl/projections/interface_fwd.h>
 #include <knp/backends/cpu-library/impl/projections/training/stdp/interface.h>
 #include <knp/core/message_endpoint.h>
 #include <knp/core/projection.h>

knp/backends/cpu/cpu-library/include/knp/backends/cpu-library/impl/projections/delta/interface.h

@@ -19,9 +19,6 @@
  */
 #pragma once
 
-// This include does not work at the end of the day. But its here so code analyzer will work properly.
-#include <knp/backends/cpu-library/impl/projections/interface_fwd.h>
-
 #include <unordered_map>
 #include <vector>
 

knp/backends/cpu/cpu-library/include/knp/backends/cpu-library/impl/projections/interface_fwd.h

@@ -28,10 +28,16 @@
 #include <unordered_map>
 #include <vector>
 
-#include "shared/def.h"
 
+namespace knp::backends::cpu::projections
+{
+
+/**
+ * @brief Type of the message queue.
+ */
+using MessageQueue = std::unordered_map<uint64_t, knp::core::messaging::SynapticImpactMessage>;
 
-namespace knp::backends::cpu::projections::impl
+namespace impl
 {
 
 /**
@@ -64,4 +70,5 @@ void calculate_projection_multithreaded_interface(
     knp::core::Projection<Synapse> &projection, const std::unordered_map<knp::core::Step, size_t> &message_in_data,
     MessageQueue &future_messages, uint64_t step_n, size_t part_start, size_t part_size, std::mutex &mutex);
 
-}  //namespace knp::backends::cpu::projections::impl
+}  //namespace impl
+}  //namespace knp::backends::cpu::projections