Commit 386ad26
docs: add repo health — the question a code reviewer actually has (#13)
The README already answered "are the contracts live" well: dated receipts, real
token IDs, basescan links, honest gaps noted inline. It did not answer "is this
codebase healthy", which is what a reviewer opens a repo to find out.
Adds one table of things a reviewer can run locally, and one of what is known
broken. Every row re-verified today before committing:
npm ci exit 0
CI 4 jobs (install / contracts / coverage-map)
HAL parity 11/11
contract suite 61 tests execute
And the part that matters most, stated where it cannot be missed rather than
buried: 26 of 61 ReputationRegistry tests fail, and it is ONE defect, not 26.
`NewFeedback` in the Solidity source carries a 12th parameter (bytes
x402PaymentProof) that appears in neither ERC8004SPEC.md:224 nor the checked-in
abis/ReputationRegistry.json — both specify 11. That changes the event
signature, so an ERC-8004-compliant indexer filtering the canonical topic0 sees
ZERO feedback events from this contract. Diagnosed and left alone: the spec's
owner decides the fix.
A reviewer who hits that suite cold concludes the contracts are broken. A
reviewer who reads this concludes there is one conformance decision outstanding.
Those are very different impressions of the same repository.
Also states plainly, with the 404s that prove it, that @hyperdag/protocol and
all six named default packages are unpublished, and that the kernel source is
branch-only — then points at @hyperdag/trustshell, which IS published and
reaches the same contracts. A reviewer should leave with something they can
actually install.
No new claims. Every line is a command someone can run or a link they can open.
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>1 parent 2d18b50 commit 386ad26
1 file changed
Lines changed: 31 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
27 | 58 | | |
28 | 59 | | |
29 | 60 | | |
| |||
0 commit comments