Skip to content

Commit 9bd088b

Browse files
OtabekRintarom-reuter
authored andcommitted
Add claryfing comments to brew update
1 parent bf8df2f commit 9bd088b

File tree

3 files changed

+8
-1
lines changed

3 files changed

+8
-1
lines changed

.github/workflows/deploy.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ jobs:
3131
run: |
3232
python -m pip install py2app tomli
3333
34+
# update system to the newest version, not pin pointing package version on purpose
3435
brew update
3536
brew upgrade || true
3637
brew install aria2

tools/macos_build/.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,4 @@ scripts/postinstall
99
scripts_intell/postinstall
1010
dist/
1111
resources/
12+
FastSurferPackageContent/

tools/macos_build/build_release_package.sh

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ RESOURCES_DIR="$build_dir/resources"
3333
PACKAGE_NAME=FastSurfer$VERSION_NO_DOTS-macos-darwin_${ARCH_TYPE_NAME}
3434
# package identifier (f.e. com.mycompany.productid)
3535
ID="org.deep-mi.FastSurfer.${VERSION_NO_DOTS}_${ARCH_TYPE_NAME}"
36-
# FIXME: Must this be fixed or can this also be different?
3736
# install location for the content of the package
3837
INSTALLATION_DIR="/Applications"
3938
# raw package file to be created
@@ -54,6 +53,12 @@ rsync -av --progress "$FASTSURFER_HOME/" "$FASTSURFER_TO_PACKAGE" \
5453
# install freesurfer into temp folder
5554
"$tools_dir/build/install_fs_pruned.sh" "$STAGED_DIR" --upx --url "$URL_TO_FREESURFER"
5655

56+
if [[ ! -d "$STAGED_DIR/freesurfer" ]]
57+
then
58+
echo "FreeSurfer install was unsuccessful!"
59+
exit 1
60+
fi
61+
5762
SCRIPTS_DIR="$tools_dir/macos_build/scripts" # directory with scripts executed during installation process (f.e. preinstall postinstall)
5863
PYTHON_VERSION_TEMP=$(python3 "$tools_dir/read_toml.py" --file "$FASTSURFER_HOME/pyproject.toml" --key project.requires-python)
5964
PYTHON_VERSION="${PYTHON_VERSION_TEMP#>=}"

0 commit comments

Comments
 (0)