Open
Description
Describe the bug
According to RFC1738 a HTTP URL takes the form of http://<host>:<port>/<path>?<searchpart>
.
When setting the serverUrl
in the TranslatorOptions
, it only replaces the host:port
part.
To Reproduce
Construct a new Translator:
const translator = new deepl.Translator(
process.env.DEEPL_API_KEY,
{
serverUrl: 'http://some-other-host.com/resource',
},
);
Translate something through this translator and the server at http://some-other-host.com
will receive POST /resource/v2/translate HTTP/1.1
.
Expected behavior
The option should replace the whole URL and not add its own path to the request.
Alternatively, it should be renamed to use the proper terminology, e.g. replaceHostAndPort
.
Metadata
Metadata
Assignees
Labels
No labels
Activity