fix(5.9): route internal calls through agent._method() for MRO safety

- tools.py: _get_available_tools fallback calls agent._load_all_tools()
- visual.py: _visual_analysis_callback calls agent._enhance_result_with_visual_context()
- workspace.py: _check_workspace_artifacts calls agent._get_workspace_path/scan
- Update test _FakeAgent classes with delegate methods
- Found by GPT-5.4 /collab review
- 1,683 passed, 127 skipped

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: Brian Krafft

openspace/agents/grounding/tools.py

@@ -60,7 +60,7 @@ async def _get_available_tools(agent, task_description: Optional[str]) -> List:
         )
     except Exception as e:
         logger.warning(f"Auto-search tools failed, falling back to full list: {e}")
-        tools = await _load_all_tools(agent, grounding_client)
+        tools = await agent._load_all_tools(grounding_client)
 
     # Append retrieve_skill tool when skill registry is available
     if agent._skill_registry and agent._skill_registry.list_skills():

openspace/agents/grounding/visual.py

@@ -78,7 +78,7 @@ async def _visual_analysis_callback(
         return result
 
     # 7. Perform visual analysis
-    return await _enhance_result_with_visual_context(agent, result, tool_name)
+    return await agent._enhance_result_with_visual_context(result, tool_name)
 
 
 async def _enhance_result_with_visual_context(

openspace/agents/grounding/workspace.py

@@ -88,11 +88,11 @@ async def _check_workspace_artifacts(agent, context: Dict[str, Any]) -> Dict[str
     workspace_info: Dict[str, Any] = {"has_files": False, "files": [], "file_details": {}, "recent_files": []}
 
     try:
-        # Get workspace path — call module-level function directly
-        workspace_path = _get_workspace_path(context)
+        # Get workspace path — route through agent for MRO preservation
+        workspace_path = agent._get_workspace_path(context)
 
-        # Scan workspace files — call module-level function directly
-        scan_result = _scan_workspace_files(workspace_path, recent_threshold=600)
+        # Scan workspace files — route through agent for MRO preservation
+        scan_result = agent._scan_workspace_files(workspace_path, recent_threshold=600)
 
         if scan_result["files"]:
             workspace_info["has_files"] = True

tests/test_grounding_tools.py

@@ -29,6 +29,11 @@ def __init__(self):
     def has_skill_context(self) -> bool:
         return self._skill_context is not None
 
+    async def _load_all_tools(self, grounding_client):
+        """Delegate for MRO — calls module function."""
+        from openspace.agents.grounding.tools import _load_all_tools
+        return await _load_all_tools(self, grounding_client)
+
 
 # ── _get_available_tools ───────────────────────────────────────────
 

tests/test_grounding_visual.py

@@ -45,6 +45,11 @@ def __init__(self):
         self._visual_analysis_timeout = 5.0
         self._current_instruction = "test instruction"
 
+    async def _enhance_result_with_visual_context(self, result, tool_name):
+        """Delegate for MRO — calls module function."""
+        from openspace.agents.grounding.visual import _enhance_result_with_visual_context
+        return await _enhance_result_with_visual_context(self, result, tool_name)
+
 
 # ── _select_key_screenshots (pure function) ────────────────────────
 

tests/test_grounding_workspace.py

@@ -117,9 +117,17 @@ def test_files_sorted_alphabetically(self):
 
 
 class _FakeAgent:
-    """Minimal stand-in — workspace module calls module-level functions directly,
-    so agent is only used as first parameter for _check_workspace_artifacts."""
-    pass
+    """Minimal stand-in — workspace module now routes through agent._method()."""
+
+    @staticmethod
+    def _get_workspace_path(context):
+        from openspace.agents.grounding.workspace import _get_workspace_path
+        return _get_workspace_path(context)
+
+    @staticmethod
+    def _scan_workspace_files(workspace_path, recent_threshold=600):
+        from openspace.agents.grounding.workspace import _scan_workspace_files
+        return _scan_workspace_files(workspace_path, recent_threshold)
 
 
 class TestCheckWorkspaceArtifacts: