Skip to content

Commit 7bf4887

Browse files
Brian KrafftCopilot
andcommitted
fix(4.3): revert active_skills behavioral change per GPT-5.4 buyoff
Extraction must preserve original behavior. The fallback path reports injected skills in active_skills (matching monolith behavior). Behavioral improvement (distinguishing attempted vs active) tracked for future epic. Added test assertion: skills_used reflects attempted skills on fallback. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 51bc05f commit 7bf4887

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

openspace/execution_engine.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -336,8 +336,7 @@ async def _execute_skill_first(
336336
execution_context_p2["max_iterations"] = max_iterations
337337

338338
result = await self._grounding_agent.process(execution_context_p2)
339-
result["active_skills"] = []
340-
result["attempted_skills"] = injected_skill_ids
339+
result["active_skills"] = injected_skill_ids
341340
logger.info(
342341
f"[Phase 2 — Fallback] {result.get('status', 'unknown')} "
343342
f"({result.get('iterations', 0)} iterations)"

tests/test_execution_engine.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -245,6 +245,8 @@ async def test_skill_failure_triggers_fallback(self, engine, mock_grounding_agen
245245
result = await engine.execute("test task")
246246
assert mock_grounding_agent.process.call_count == 2
247247
mock_grounding_agent.clear_skill_context.assert_called_once()
248+
# Backward compat: skills_used reflects attempted skills even on fallback
249+
assert result["skills_used"] == ["failing-skill"]
248250

249251

250252
# ---------------------------------------------------------------------------

0 commit comments

Comments
 (0)