Commit ab585cc
fix(P4/4.1): address review findings from /8eyes + /collab
Round 1 fixes:
- Fix llm_kwargs spread order so explicit timeout/max_retries take precedence (L3)
- Add skills.enabled guard inside ToolRegistry.discover() (F4)
- Remove dead agent-None guard in select_and_inject (M2)
- Expand test suite: 15 → 23 tests covering:
- skills.enabled=False path
- grounding_config=None path
- store quality metrics forwarding
- store exception swallowing
- no-LLM skip path
- backend_scope forwarding
- LLM returns None when all options exhausted
- agent=None fallback to llm_client
- llm_kwargs forwarding verification
- Strengthen assertion on _tool_registry initial value
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 4f5e46b commit ab585cc
3 files changed
Lines changed: 963 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
82 | 86 | | |
83 | 87 | | |
84 | 88 | | |
| |||
201 | 205 | | |
202 | 206 | | |
203 | 207 | | |
204 | | - | |
| 208 | + | |
205 | 209 | | |
206 | 210 | | |
207 | 211 | | |
| |||
223 | 227 | | |
224 | 228 | | |
225 | 229 | | |
| 230 | + | |
226 | 231 | | |
227 | 232 | | |
228 | 233 | | |
229 | | - | |
230 | 234 | | |
231 | 235 | | |
232 | 236 | | |
| |||
0 commit comments