Merge pull request #70 from WimDeMeester/master

Added the moon phase ratio to the calculation of the illumination of the moon.

Author: WimDeMeester

changelog.md

@@ -2,6 +2,12 @@
 
 All notable changes to `laravel-astronomy-library` will be documented in this file.
 
+## Version 5.4.1
+
+### Added
+
+- Added the moon phase ratio to the calculation of the illumination of the moon.
+
 ## Version 5.4
 
 ### Added

src/deepskylog/AstronomyLibrary/Targets/Moon.php

@@ -369,11 +369,11 @@ private function _calculateEquatorialCoordinates(Carbon $date, GeographicalCoord
      *
      * @param Carbon $date The date for which to calculate the fraction
      *
-     * @return float The illuminated fraction
+     * @return array The illuminated fraction, the phase ratio
      *
      * See chapter 58 of Astronomical Algorithms
      */
-    public function illuminatedFraction(Carbon $date): float
+    public function illuminatedFraction(Carbon $date): array
     {
         // T = julian centuries since epoch J2000.0
         $T = (Time::getJd($date) - 2451545.0) / 36525.0;
@@ -396,6 +396,6 @@ public function illuminatedFraction(Carbon $date): float
 
         $i = $i - floor($i / 360.0) * 360.0;
 
-        return (1 + cos(deg2rad($i))) / 2;
+        return [round((1 + cos(deg2rad($i))) / 2, 3), $i / 360];
     }
 }

tests/Unit/TargetTest.php

@@ -958,7 +958,7 @@ public function testMoonIllumination()
     {
         $date = Carbon::create(1992, 4, 12, 0, 0, 0, 'UTC');
         $moon = new Moon();
-        $illum = $moon->illuminatedFraction($date);
+        $illum = $moon->illuminatedFraction($date)[0];
 
         $this->assertEqualsWithDelta(0.680, $illum, 0.001);
     }