oracle_test.go

// Copyright © 2025, Oracle and/or its affiliates.

package oracle

import (
	"context"
	"database/sql"
	"strings"
	"testing"

	"github.com/google/go-cmp/cmp"
	"github.com/googleapis/genai-toolbox/internal/server"
	"github.com/googleapis/genai-toolbox/internal/sources"
	"github.com/googleapis/genai-toolbox/internal/testutils"
)

func TestParseFromYamlOracle(t *testing.T) {
	tcs := []struct {
		desc string
		in   string
		want server.SourceConfigs
	}{
		{
			desc: "connection string and useOCI=true",
			in: `
			kind: sources
			name: my-oracle-cs
			type: oracle
			connectionString: "my-host:1521/XEPDB1"
			user: my_user
			password: my_pass
			useOCI: true
			`,
			want: map[string]sources.SourceConfig{
				"my-oracle-cs": Config{
					Name:             "my-oracle-cs",
					Type:             SourceType,
					ConnectionString: "my-host:1521/XEPDB1",
					User:             "my_user",
					Password:         "my_pass",
					UseOCI:           true,
				},
			},
		},
		{
			desc: "host/port/serviceName and default useOCI=false",
			in: `
			kind: sources
			name: my-oracle-host
			type: oracle
			host: my-host
			port: 1521
			serviceName: ORCLPDB
			user: my_user
			password: my_pass
			`,
			want: map[string]sources.SourceConfig{
				"my-oracle-host": Config{
					Name:        "my-oracle-host",
					Type:        SourceType,
					Host:        "my-host",
					Port:        1521,
					ServiceName: "ORCLPDB",
					User:        "my_user",
					Password:    "my_pass",
					UseOCI:      false,
				},
			},
		},
		{
			desc: "tnsAlias and TnsAdmin specified with explicit useOCI=true",
			in: `
			kind: sources
			name: my-oracle-tns-oci
			type: oracle
			tnsAlias: FINANCE_DB
			tnsAdmin: /opt/oracle/network/admin
			user: my_user
			password: my_pass
			useOCI: true 
			`,
			want: map[string]sources.SourceConfig{
				"my-oracle-tns-oci": Config{
					Name:     "my-oracle-tns-oci",
					Type:     SourceType,
					TnsAlias: "FINANCE_DB",
					TnsAdmin: "/opt/oracle/network/admin",
					User:     "my_user",
					Password: "my_pass",
					UseOCI:   true,
				},
			},
		},
	}
	for _, tc := range tcs {
		t.Run(tc.desc, func(t *testing.T) {
			got, _, _, _, _, _, err := server.UnmarshalResourceConfig(context.Background(), testutils.FormatYaml(tc.in))
			if err != nil {
				t.Fatalf("unable to unmarshal: %s", err)
			}
			if !cmp.Equal(tc.want, got) {
				t.Fatalf("incorrect parse:\nwant: %v\ngot:  %v\ndiff: %s", tc.want, got, cmp.Diff(tc.want, got))
			}
		})
	}
}

func TestFailParseFromYaml(t *testing.T) {
	tcs := []struct {
		desc string
		in   string
		err  string
	}{
		{
			desc: "extra field",
			in: `
			kind: sources
			name: my-oracle-instance
			type: oracle
			host: my-host
			serviceName: ORCL
			user: my_user
			password: my_pass
			extraField: value
			`,
			err: "error unmarshaling sources: unable to parse source \"my-oracle-instance\" as \"oracle\": [1:1] unknown field \"extraField\"\n>  1 | extraField: value\n       ^\n   2 | host: my-host\n   3 | name: my-oracle-instance\n   4 | password: my_pass\n   5 | ",
		},
		{
			desc: "missing required password field",
			in: `
			kind: sources
			name: my-oracle-instance
			type: oracle
			host: my-host
			serviceName: ORCL
			user: my_user
			`,
			err: "error unmarshaling sources: unable to parse source \"my-oracle-instance\" as \"oracle\": Key: 'Config.Password' Error:Field validation for 'Password' failed on the 'required' tag",
		},
		{
			desc: "missing connection method fields (validate fails)",
			in: `
			kind: sources
			name: my-oracle-instance
			type: oracle
			user: my_user
			password: my_pass
			`,
			err: "error unmarshaling sources: unable to parse source \"my-oracle-instance\" as \"oracle\": invalid Oracle configuration: must provide one of: 'tns_alias', 'connection_string', or both 'host' and 'service_name'",
		},
		{
			desc: "multiple connection methods provided (validate fails)",
			in: `
			kind: sources
			name: my-oracle-instance
			type: oracle
			host: my-host
			serviceName: ORCL
			connectionString: "my-host:1521/XEPDB1"
			user: my_user
			password: my_pass
			`,
			err: "error unmarshaling sources: unable to parse source \"my-oracle-instance\" as \"oracle\": invalid Oracle configuration: provide only one connection method: 'tns_alias', 'connection_string', or 'host'+'service_name'",
		},
		{
			desc: "fail on tnsAdmin with useOCI=false",
			in: `
			kind: sources
			name: my-oracle-fail
			type: oracle
			tnsAlias: FINANCE_DB
			tnsAdmin: /opt/oracle/network/admin
			user: my_user
			password: my_pass
			useOCI: false
			`,
			err: "error unmarshaling sources: unable to parse source \"my-oracle-fail\" as \"oracle\": invalid Oracle configuration: `tnsAdmin` can only be used when `UseOCI` is true, or use `walletLocation` instead",
		},
	}
	for _, tc := range tcs {
		t.Run(tc.desc, func(t *testing.T) {
			_, _, _, _, _, _, err := server.UnmarshalResourceConfig(context.Background(), testutils.FormatYaml(tc.in))
			if err == nil {
				t.Fatalf("expect parsing to fail")
			}
			errStr := strings.ReplaceAll(err.Error(), "\r", "")

			if errStr != tc.err {
				t.Fatalf("unexpected error:\ngot:\n%q\nwant:\n%q\n", errStr, tc.err)
			}
		})
	}
}

// TestRunSQLExecutesDML verifies that RunSQL correctly routes operations to
// ExecContext instead of QueryContext when the readOnly flag is set to false.
func TestRunSQLExecutesDML(t *testing.T) {
	// Initialize a mock database connection.
	// This connection is not established with a real backend but
	// satisfies the interface requirements for the test.
	db, err := sql.Open("oracle", "oracle://user:pass@localhost:1521/service")
	if err != nil {
		t.Fatalf("failed to open mock db: %v", err)
	}
	defer db.Close()

	src := &Source{
		Config: Config{
			Name: "test-dml-source",
			Type: SourceType,
			User: "test-user",
		},
		DB: db,
	}

	// Invoke RunSQL with readOnly=false to force the DML execution path.
	_, err = src.RunSQL(context.Background(),
		"UPDATE users SET email='x' WHERE id=1", nil, false)

	// We expect an error because the mock database cannot execute the query.
	// If err is nil, it implies the logic skipped the execution block.
	if err == nil {
		t.Fatal("expected error from fake DB execution, but got nil; " +
			"DML path may not have been executed")
	}
}

func TestBuildGoOraConnString(t *testing.T) {
	t.Parallel()

	testCases := []struct {
		name           string
		user           string
		password       string
		connBase       string
		walletLocation string
		want           string
	}{
		{
			name:           "encodes credentials and wallet",
			user:           "user[client]",
			password:       "pa:ss@word",
			connBase:       "dbhost:1521/XEPDB1",
			walletLocation: "/tmp/my wallet",
			want:           "oracle://user%5Bclient%5D:pa%3Ass%40word@dbhost:1521/XEPDB1?ssl=true&wallet=%2Ftmp%2Fmy+wallet",
		},
		{
			name:           "no wallet",
			user:           "scott",
			password:       "tiger",
			connBase:       "dbhost:1521/ORCL",
			walletLocation: "",
			want:           "oracle://scott:tiger@dbhost:1521/ORCL",
		},
		{
			name:           "does not double encode percent encoded user",
			user:           "app_user%5BCLIENT_A%5D",
			password:       "secret",
			connBase:       "dbhost:1521/ORCL",
			walletLocation: "",
			want:           "oracle://app_user%5BCLIENT_A%5D:secret@dbhost:1521/ORCL",
		},
		{
			name:           "uses trimmed wallet location",
			user:           "scott",
			password:       "tiger",
			connBase:       "dbhost:1521/ORCL",
			walletLocation: "  /tmp/wallet  ",
			want:           "oracle://scott:tiger@dbhost:1521/ORCL?ssl=true&wallet=%2Ftmp%2Fwallet",
		},
		{
			name:           "preserves existing query without wallet",
			user:           "scott",
			password:       "tiger",
			connBase:       "dbhost:1521/ORCL?transport_connect_timeout=30",
			walletLocation: "",
			want:           "oracle://scott:tiger@dbhost:1521/ORCL?transport_connect_timeout=30",
		},
		{
			name:           "merges existing query with wallet",
			user:           "scott",
			password:       "tiger",
			connBase:       "dbhost:1521/ORCL?foo=bar",
			walletLocation: "/tmp/wallet",
			want:           "oracle://scott:tiger@dbhost:1521/ORCL?foo=bar&ssl=true&wallet=%2Ftmp%2Fwallet",
		},
		{
			name:           "preserves malformed existing query when appending wallet",
			user:           "scott",
			password:       "tiger",
			connBase:       "dbhost:1521/ORCL?already=%ZZ",
			walletLocation: "/tmp/wallet",
			want:           "oracle://scott:tiger@dbhost:1521/ORCL?already=%ZZ&ssl=true&wallet=%2Ftmp%2Fwallet",
		},
	}

	for _, tc := range testCases {
		tc := tc
		t.Run(tc.name, func(t *testing.T) {
			t.Parallel()
			config := Config{
				User:             tc.user,
				Password:         tc.password,
				ConnectionString: tc.connBase,
				WalletLocation:   tc.walletLocation,
			}
			got, _ := buildGoOraConnString(config)
			if got != tc.want {
				t.Fatalf("buildGoOraConnString() = %q, want %q", got, tc.want)
			}
		})
	}
}