Skip to content

Windows e2e runner reports awk failure #5

@brad-defined

Description

@brad-defined

The Windows e2e runner reports the following error:

Run make e[2](https://github.com/DefinedNet/nebula/runs/5554733633?check_suite_focus=true#step:8:2)evv
  make e2evv
  shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"
  env:
    GOROOT: C:\hostedtoolcache\windows\go\1.17.7\x64
awk: cmd. line:1: {print substr(, [3](https://github.com/DefinedNet/nebula/runs/5554733633?check_suite_focus=true#step:8:3))}
awk: cmd. line:1:               ^ syntax error
awk: cmd. line:1: {print substr(, 3)}
awk: cmd. line:1:                  ^ 1 is invalid as number of arguments for substr
/usr/bin/bash: IF: command not found

Here: https://github.com/DefinedNet/nebula/runs/5554733633?check_suite_focus=true#step:8:1

Looks to be an issue in the Makefile

# Set up OS specific bits
ifeq ($(OS),Windows_NT)
	#TODO: we should be able to ditch awk as well
	GOVERSION := $(shell go version | awk "{print substr($$3, 3)}")
	GOISMIN := $(shell IF "$(GOVERSION)" GEQ "$(GOMINVERSION)" ECHO 1)
	NEBULA_CMD_SUFFIX = .exe
	NULL_FILE = nul
else
	GOVERSION := $(shell go version | awk '{print substr($$3, 3)}')
	GOISMIN := $(shell expr "$(GOVERSION)" ">=" "$(GOMINVERSION)")
	NEBULA_CMD_SUFFIX =
	NULL_FILE = /dev/null
endif

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions