-
Notifications
You must be signed in to change notification settings - Fork 1
Description
Hi,
I tried the plugin in general and I have a couple of issues that I faced so I just want to make note, maybe can be fixed/re-thing in a future :)
Fix Multisite Config- Works perfect 👍 Out of the box! LOVE IT!Root pathandRemote image URL:
-
There is no way to apply one of them.
-
For some reason when applied it also remove
{{#unless site.multiSite}}
include includes/wordpress-single.conf;
{{else}}
include includes/wordpress-multi.conf;
{{/unless}}and keep only
include includes/wordpress-multi.conf;
Which would cause issue with non multisites.
-
Remote Images: When I remove the link it just use blank which cause the issue - maybe use default then?
-
502 When passed the incorrect link - I have learned just slash at the end is incorrect. so maybe just run the user input or saved link through e.g:
export const trimLink = (link) => {
if (!link) return ''
const re = new RegExp(/^\/|\/$/g)
return link.replace(re, '')
}or simply if one time use: test.replace(/^\/|\/$/g, ''); and this would remove the last slash.
I spend like hour debugging what is wrong ... so this would improve it a lot.
-
The Root is not loaded from file. Basically If I have set it already, the plugin does not load current setting of the root path. Which cause the issue if I just want to apply Remote image. It is more like for noobs like me who don't know how the whole thing works :).
-
There is no way back. It would be nice to have way back. E.g if user click click apply, just create backup of the file if there is no backup. so we could restore the old file easy :).
I know this is a lot, if I find time I'll try to contribute.
At this point those are more like notes :)