Skip to content

Commit cde4ddd

Browse files
committed
feat: Simplify assertions
1 parent 97c1a22 commit cde4ddd

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

src/test/java/tooling/leyden/commands/logparser/AOTCacheParserTest.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ void accept() throws Exception {
4141
File file = new File(getClass().getResource("aot.map").getPath());
4242
final var aotCache = getDefaultCommand().getInformation();
4343
getSystemRegistry().execute("load aotCache " + file.getAbsolutePath().replace('\\', '/'));
44-
assertTrue(!aotCache.getAll().isEmpty());
44+
assertFalse(aotCache.getAll().isEmpty());
4545
assertEquals(0, aotCache.getWarnings().size());
4646

4747
//Now check individual values
@@ -94,10 +94,10 @@ void acceptObjectsWithReferences() {
9494
final var objects = information.getElements(null, null, null, true, false, "Object").toList();
9595
assertEquals(6, information.getElements(null, null, null, true, false, "Object").count());
9696
for (Element e : objects) {
97-
assertTrue(e instanceof ReferencingElement);
97+
assertInstanceOf(ReferencingElement.class, e);
9898
ReferencingElement re = (ReferencingElement) e;
9999
if (!re.getKey().equals("(0xfff632f0) [I length: 0")) {
100-
assertTrue(!re.getReferences().isEmpty());
100+
assertFalse(re.getReferences().isEmpty());
101101
assertTrue(re.getKey().contains(re.getReferences().getFirst().getKey()));
102102
}
103103
}
@@ -114,7 +114,7 @@ void acceptSymbol() {
114114
assertEquals(2, information.getElements(null, null, null, true, false, "Symbol").count());
115115
assertEquals(1, information.getElements(null, null, null, true, false, "Class").count());
116116
for (Element e : information.getElements(null, null, null, true, false, "Symbol").toList()) {
117-
assertTrue(e instanceof ReferencingElement);
117+
assertInstanceOf(ReferencingElement.class, e);
118118
assertEquals(1, ((ReferencingElement) e).getReferences().size());
119119
}
120120
ClassObject classObject = (ClassObject) information.getElements(null, null, null, true, false, "Class").findAny().get();
@@ -190,8 +190,8 @@ void acceptObjectsWithExplicitReference() {
190190

191191
for (Element e : information.getElements(null, null, null, true, false,
192192
"Object").toList()) {
193-
assertTrue(e instanceof ReferencingElement);
194-
assertTrue(!((ReferencingElement) e).getReferences().isEmpty(), e + " should have at least a reference");
193+
assertInstanceOf(ReferencingElement.class, e);
194+
assertFalse(((ReferencingElement) e).getReferences().isEmpty(), e + " should have at least a reference");
195195
}
196196

197197
assertEquals(3 + 1, information.getElements(null, null, null, true, false, "Class").count());
@@ -245,13 +245,13 @@ void acceptMethodDataAndMethodCounters() {
245245
var elements = information.getElements(null, null, null, true, false, "MethodData").toList();
246246
assertEquals(9, elements.size());
247247
for (Element e : elements) {
248-
assertTrue(!((ReferencingElement) e).getReferences().isEmpty());
248+
assertFalse(((ReferencingElement) e).getReferences().isEmpty());
249249
}
250250

251251
elements = information.getElements(null, null, null, true, false, "MethodCounters").toList();
252252
assertEquals(7, elements.size());
253253
for (Element e : elements) {
254-
assertTrue(!((ReferencingElement) e).getReferences().isEmpty());
254+
assertFalse(((ReferencingElement) e).getReferences().isEmpty());
255255
}
256256

257257
elements = information.getElements("void jdk.internal.misc.CDS.keepAlive(java.lang.Object)",

0 commit comments

Comments
 (0)