Commit 437b091
authored
Fix CI failures due to removed runners in Github Actions (#1354)
The "ubuntu-20.04" runner was removed a few months ago, causing the
Loguru CI to repeatedly fail since then. On top of that, migrating to
"ubuntu-22.04" or "ubuntu-24.04" was not straightforward because these
runners were incompatible with "actions/setup-python" for Python 3.5 and
3.6.
As a workaround, I replaced "actions/setup-python" with a "python-slim"
Docker image for these versions that went unsupported. That's probably
the closest we can get to a stable and reproducible CI setup that won't
break overnight due to upstream decisions. ;)
Eventually, this solution will likely need to be repeated for other
Python versions as theyh become deprecated. I've considered defaulting
to a Docker image, but I assume the recommended approach is still
to favor "actions/setup-python" when it's available.
Additionally, because "actions/download-artifact" would not work within
the Docker image (conflicting GLIB versions between the OS and their
executable), I've moved the Codecov upload to a later stage in charge
of uploading all the coverage reports once the tests have been completed.
The downside is that we lose the "flags" that enabled us to identify
coverage reports individually on Codecov. But I don't know if we can do
otherwise.1 parent a69bfc4 commit 437b091
1 file changed
+24
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
| 32 | + | |
| 33 | + | |
33 | 34 | | |
34 | 35 | | |
| 36 | + | |
35 | 37 | | |
36 | 38 | | |
37 | 39 | | |
| |||
42 | 44 | | |
43 | 45 | | |
44 | 46 | | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
45 | 51 | | |
46 | 52 | | |
47 | 53 | | |
48 | 54 | | |
| 55 | + | |
49 | 56 | | |
50 | 57 | | |
51 | 58 | | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | 59 | | |
56 | 60 | | |
57 | 61 | | |
| |||
60 | 64 | | |
61 | 65 | | |
62 | 66 | | |
63 | | - | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
64 | 82 | | |
65 | 83 | | |
66 | 84 | | |
67 | | - | |
68 | 85 | | |
69 | 86 | | |
70 | | - | |
| |||
0 commit comments