Show header on options page only for tab mode

Deliaz · Deliaz · commit 492cb67e826a · 2017-02-09T22:09:19.000+03:00
diff --git a/css/options.css b/css/options.css
@@ -88,4 +88,8 @@ body {
 
 .b-options__button-save_animated {
     animation: changeBgc 2.7s;
+}
+
+.b-container__main-header_hidden {
+    display: none;
 }
diff --git a/js/options.js b/js/options.js
@@ -6,6 +6,7 @@ class Options {
 
     init() {
         this.selectElements();
+        this.showHeader();
         this.loadSettings();
         this.showSettings();
         this.startHandlers();
@@ -17,11 +18,21 @@ class Options {
         this.el = {
             storageSelect: qs('.js-select-storage'),
             themeSelect: qs('.js-select-theme'),
-            saveBtn: qs('.js-save-button')
+            saveBtn: qs('.js-save-button'),
+            header: qs('.js-options-header')
         }
     }
 
 
+    /**
+     * Show main header if 'show_header' flag set in url
+     */
+    showHeader() {
+        if(window.location.search.includes('show_header')) {
+            this.el.header.classList.remove('b-container__main-header_hidden');
+        }
+    }
+
     /**
      * Load saved settings of set defaults instead
      */
diff --git a/js/panel.js b/js/panel.js
@@ -273,12 +273,7 @@ class WebStorageExplorer {
             e.preventDefault();
             this.el.showSubnavBtn.trigger(':hide');
 
-            if (chrome.runtime.openOptionsPage) {
-                chrome.runtime.openOptionsPage();
-            } else {
-                // TODO remove when crbug.com/679167 will be resolved
-                window.open(chrome.runtime.getURL('options.html'));
-            }
+            window.open(chrome.runtime.getURL('options.html?show_header'));
         });
 
         // Open links from json view in a new tab
diff --git a/manifest.json b/manifest.json
@@ -2,7 +2,7 @@
   "manifest_version": 2,
   "name": "Web Storage Explorer",
   "short_name": "WebStorageX",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "minimum_chrome_version": "42",
   "description": "Developer tool for exploring localStorage and sessionStorage which lets you parse values",
   "author": "Deliaz",
diff --git a/options.html b/options.html
@@ -7,7 +7,7 @@
 </head>
 <body>
 <div class="b-container">
-    <h1 class="b-container__main-header">Web Storage Explorer options</h1>
+    <h1 class="b-container__main-header b-container__main-header_hidden js-options-header">Web Storage Explorer options</h1>
 
     <div class="b-options">
         <div class="b-options__setting">
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "chrome-webstorage-explorer",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "",
   "main": "manifest.json",
   "scripts": {

Original file line number	Diff line number	Diff line change
`@@ -88,4 +88,8 @@ body {`
`88`	`88`
`89`	`89`	`.b-options__button-save_animated {`
`90`	`90`	`animation: changeBgc 2.7s;`
	`91`	`+}`
	`92`	`+`
	`93`	`+.b-container__main-header_hidden {`
	`94`	`+ display: none;`
`91`	`95`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "chrome-webstorage-explorer",`
`3`		`- "version": "1.0.2",`
	`3`	`+ "version": "1.0.3",`
`4`	`4`	`"description": "",`
`5`	`5`	`"main": "manifest.json",`
`6`	`6`	`"scripts": {`