pylint

Author: wschoonveld

decoimpact/business/entities/rules/time_aggregation_rule.py

@@ -105,7 +105,7 @@ def execute(self, value_array: _xr.DataArray, logger: ILogger) -> _xr.DataArray:
             value_array = value_array.sel({time_dim_name: slice_obj})
             grouped_values = value_array.groupby(f"{time_dim_name}.month")
             result = self._perform_grouping_operation(
-                grouped_values, settings.operation_type, time_dim_name
+                grouped_values, settings.operation_type
             )
             # create a new aggregated time dimension based on original time dimension
             result_time_dim_name = f"{time_dim_name}_monthly"
@@ -136,7 +136,6 @@ def _perform_grouping_operation(
         self,
         grouped_values,
         operation_type: TimeOperationType,
-        time_dim_name: str,
     ) -> _xr.DataArray:
         """Returns the values based on the grouping operation type
 

decoimpact/data/api/i_time_aggregation_rule_data.py

@@ -14,8 +14,7 @@
 
 
 from abc import ABC, abstractmethod
-
-from pyparsing import Optional
+from typing import Optional
 
 from decoimpact.data.api.i_rule_data import IRuleData
 from decoimpact.data.api.time_operation_type import TimeOperationType

tests/business/entities/rules/test_time_aggregation_rule.py

@@ -464,7 +464,7 @@ def test_multi_year_monthly_average():
 
 
 def test_multi_yearly_month_average_with_year_range():
-    """Aggregate input_variable_names of a TimeAggregationRule (average, months) with year range"""
+    """Aggregate multi-year monthly average of a TimeAggregationRule with year range"""
 
     # create test set
     logger = Mock(ILogger)