Fixed some issues

Author: HiddeElzinga

Dockerfile

@@ -8,10 +8,8 @@ WORKDIR /decoimpact
 COPY . .
 
 # Update the package source list, update system packages
-RUN apt-get update && apt-get upgrade -y
-
-# install poetry (/usr/local/bin/poetry)
-RUN pip install poetry
+RUN apt-get update && apt-get upgrade -y \
+    && pip install poetry
 
 # Install Poetry dependencies without creating poetry environment
 ## Packages are installed in "/usr/local/lib/python/site-packages/" when the environment is not created,

tests/data/parsers/test_parser_step_function_rule.py

@@ -19,41 +19,37 @@
 
 
 def _get_example_step_function_dict():
-    return dict(
-        {
-            "name": "Apply chloride policy",
-            "description": "this rules indicates whether the chloride policy should be applied (1.0) or not (0.0) depending on the chloride concentration.",
-            "limit_response_table": [
-                ["limit", "response"],
-                [1.0, 1.0],
-                [450, 0.0],
-            ],
-            "input_variable": "chloride_top_layer",
-            "output_variable": "response_chloride_top_layer",
-        }
-    )
+    return {
+        "name": "Apply chloride policy",
+        "description": "this rules indicates whether the chloride policy should be applied (1.0) or not (0.0) depending on the chloride concentration.",
+        "limit_response_table": [
+            ["limit", "response"],
+            [1.0, 1.0],
+            [450, 0.0],
+        ],
+        "input_variable": "chloride_top_layer",
+        "output_variable": "response_chloride_top_layer",
+    }
 
 
 def test_parser_step_function_rule_correct_input():
     """The ParserStepFunctionRule should parse the provided dictionary
     to correctly initialize itself during creation"""
 
     # Arrange
-    new_dict = dict(
-        {
-            "name": "Test name",
-            "description": "Test description",
-            "limit_response_table": [
-                ["limit", "response"],
-                [0.0, 10.0],
-                [1.0, 20.0],
-                [2.0, 30.0],
-                [10.0, 40.0],
-            ],
-            "input_variable": "test input variable name",
-            "output_variable": "test output variable name",
-        }
-    )
+    new_dict = {
+        "name": "Test name",
+        "description": "Test description",
+        "limit_response_table": [
+            ["limit", "response"],
+            [0.0, 10.0],
+            [1.0, 20.0],
+            [2.0, 30.0],
+            [10.0, 40.0],
+        ],
+        "input_variable": "test input variable name",
+        "output_variable": "test output variable name",
+    }
     parser = ParserStepFunctionRule()
     logger = Mock(ILogger)
 
@@ -100,28 +96,26 @@ def test_parser_does_not_change_ordered__limits():
     """If the limits are sorted, the ParserStepFunctionRule
     should not modify the order."""
     # Arrange
-    rule_dict = dict(
-        {
-            "name": "Test name",
-            "description": "Test description",
-            "limit_response_table": [
-                ["limit", "response"],
-                [0.0, 0.0],
-                [1.0, 10.0],
-                [2.0, 20.0],
-                [3.0, 30.0],
-                [4.0, 40.0],
-                [5.0, 50.0],
-                [6.0, 60.0],
-                [7.0, 70.0],
-                [8.0, 80.0],
-                [9.0, 90.0],
-                [10.0, 100.0],
-            ],
-            "input_variable": "test input variable name",
-            "output_variable": "test output variable name",
-        }
-    )
+    rule_dict = {
+        "name": "Test name",
+        "description": "Test description",
+        "limit_response_table": [
+            ["limit", "response"],
+            [0.0, 0.0],
+            [1.0, 10.0],
+            [2.0, 20.0],
+            [3.0, 30.0],
+            [4.0, 40.0],
+            [5.0, 50.0],
+            [6.0, 60.0],
+            [7.0, 70.0],
+            [8.0, 80.0],
+            [9.0, 90.0],
+            [10.0, 100.0],
+        ],
+        "input_variable": "test input variable name",
+        "output_variable": "test output variable name",
+    }
     parser = ParserStepFunctionRule()
     logger = Mock(ILogger)
 
@@ -137,28 +131,26 @@ def test_parser_sorts_unordered_limits():
     limits in an increasing order. The respective responses
     should also be sorted accordingly."""
     # Arrange
-    rule_dict = dict(
-        {
-            "name": "Test name",
-            "description": "Test description",
-            "limit_response_table": [
-                ["limit", "response"],
-                [0.0, 0.0],
-                [1.0, 10.0],
-                [2.0, 20.0],
-                [3.0, 30.0],
-                [4.0, 40.0],
-                [5.0, 50.0],
-                [6.0, 60.0],
-                [7.0, 70.0],
-                [8.0, 80.0],
-                [9.0, 90.0],
-                [10.0, 100.0],
-            ],
-            "input_variable": "test input variable name",
-            "output_variable": "test output variable name",
-        }
-    )
+    rule_dict = {
+        "name": "Test name",
+        "description": "Test description",
+        "limit_response_table": [
+            ["limit", "response"],
+            [0.0, 0.0],
+            [1.0, 10.0],
+            [2.0, 20.0],
+            [3.0, 30.0],
+            [4.0, 40.0],
+            [5.0, 50.0],
+            [6.0, 60.0],
+            [7.0, 70.0],
+            [8.0, 80.0],
+            [9.0, 90.0],
+            [10.0, 100.0],
+        ],
+        "input_variable": "test input variable name",
+        "output_variable": "test output variable name",
+    }
     parser = ParserStepFunctionRule()
     logger = Mock(ILogger)
     expected_log_message = "Limits were not ordered. They have been sorted increasingly, and their respective responses accordingly too."