Skip to content

Commit a6cb671

Browse files
committed
fix pylint: remove unnecessary else
1 parent 4962e40 commit a6cb671

1 file changed

Lines changed: 12 additions & 12 deletions

File tree

decoimpact/business/entities/rules/combine_results_rule.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -108,18 +108,18 @@ def _create_operations(self) -> dict[MultiArrayOperationType, Callable]:
108108
npa[0], _np.nansum(npa[1:], axis=0)
109109
),
110110
}
111-
else:
112-
return {
113-
MultiArrayOperationType.MULTIPLY: lambda npa: _np.prod(npa, axis=0),
114-
MultiArrayOperationType.MIN: lambda npa: _np.min(npa, axis=0),
115-
MultiArrayOperationType.MAX: lambda npa: _np.max(npa, axis=0),
116-
MultiArrayOperationType.AVERAGE: lambda npa: _np.average(npa, axis=0),
117-
MultiArrayOperationType.MEDIAN: lambda npa: _np.median(npa, axis=0),
118-
MultiArrayOperationType.ADD: lambda npa: _np.sum(npa, axis=0),
119-
MultiArrayOperationType.SUBTRACT: lambda npa: _np.subtract(
120-
npa[0], _np.sum(npa[1:], axis=0)
121-
),
122-
}
111+
# and if ignore_nan is False:
112+
return {
113+
MultiArrayOperationType.MULTIPLY: lambda npa: _np.prod(npa, axis=0),
114+
MultiArrayOperationType.MIN: lambda npa: _np.min(npa, axis=0),
115+
MultiArrayOperationType.MAX: lambda npa: _np.max(npa, axis=0),
116+
MultiArrayOperationType.AVERAGE: lambda npa: _np.average(npa, axis=0),
117+
MultiArrayOperationType.MEDIAN: lambda npa: _np.median(npa, axis=0),
118+
MultiArrayOperationType.ADD: lambda npa: _np.sum(npa, axis=0),
119+
MultiArrayOperationType.SUBTRACT: lambda npa: _np.subtract(
120+
npa[0], _np.sum(npa[1:], axis=0)
121+
),
122+
}
123123

124124
def _check_dimensions(self, np_arrays: List[_np.ndarray]) -> bool:
125125
"""Brief check if all the arrays to be combined have the

0 commit comments

Comments
 (0)