Merge branch 'fm/bugfix/UNST-8433_only_update_valobs_when_needed' into 'all/release/2025.01'

UNST-8433: Only update valobs when needed

See merge request oss/delft3d!1440

Author: FlorisBuwaldaDeltares

src/engines_gpl/dflowfm/packages/dflowfm_kernel/src/dflowfm_data/fm_statistical_output.f90

@@ -32,6 +32,8 @@ module fm_statistical_output
    real(dp), dimension(:), allocatable, target :: SBCX, SBCY, SBWX, SBWY, SSWX, SSWY, SSCX, SSCY
    real(dp), dimension(:), allocatable, target :: qplat_data
 
+   logical, public :: apply_statistics_on_output
+
 contains
 
    subroutine close_fm_statistical_output()
@@ -2469,7 +2471,7 @@ subroutine flow_init_statistical_output_his(output_config_set, output_set)
                call add_stat_output_items(output_set, output_config_set%configs(IDX_HIS_DISCHARGE_MAGNITUDE), valobs(:, IPNT_QMAG))
             end if
          end if
-         
+
          ! Turbulence model
          if (jahistur > 0) then
             if (model_is_3D()) then
@@ -2953,6 +2955,7 @@ subroutine flow_init_statistical_output_his(output_config_set, output_set)
       call process_output_quantity_configs(output_set)
       call realloc(output_set, .true.) ! set size to count
       call initialize_statistical_output(output_set%statout)
+      apply_statistics_on_output = any(station_statistics_requested(output_set%statout))
 
    end subroutine flow_init_statistical_output_his
 
@@ -2971,6 +2974,21 @@ subroutine process_output_quantity_configs(output_set)
 
    end subroutine process_output_quantity_configs
 
+   !> return whether the output variable item is a station where the requested operation type is a statistical one
+   elemental function station_statistics_requested(item) result(res)
+      use m_statistical_output_types, only: SO_CURRENT, SO_NONE, SO_UNKNOWN
+
+      type(t_output_variable_item), intent(in) :: item !< output variable item to check
+      logical :: res !< Return value
+
+      if (allocated(item%output_config)) then
+         res = (.not. any(item%operation_type == [SO_CURRENT, SO_NONE, SO_UNKNOWN])) .and. item%output_config%location_specifier == UNC_LOC_STATION
+      else
+         res = .false.
+      end if
+
+   end function station_statistics_requested
+
    !> Deactivate invalid dimension IDs depending on model parameters
    subroutine process_nc_dim_ids(nc_dim_ids)
       use m_sediment, only: stm_included

src/engines_gpl/dflowfm/packages/dflowfm_kernel/src/dflowfm_kernel/main/flow_finalize_single_timestep.f90

@@ -85,9 +85,15 @@ subroutine flow_finalize_single_timestep(iresult)
    call timstrt('update HIS data DtUser', handle_extra(75))
    if (ti_his > 0) then
 
-      call updateValuesOnObservationStations()
+      if (apply_statistics_on_output) then ! update every numerical timestep if statistics requested
+         call updateValuesOnObservationStations()
+      end if
 
       if (comparereal(time1, time_his, eps10) >= 0) then
+         if (.not. apply_statistics_on_output) then
+            call updateValuesOnObservationStations()
+         end if
+
          !do_fourier = do_fourier .or. (md_fou_step == 2)
          if (jampi == 1) then
             call updateValuesOnRunupGauges_mpi()