corrections following second CoPilot review

Author: hrajagers

src/tools_lgpl/matlab/quickplot/progsrc/private/int_lntri.m

@@ -191,13 +191,13 @@
 if all(noNeighborDefined)
     % no intersections with points or lines at all
     % search triangle for one point
-    [Ti,p] = tsearch_safe(xyMesh,TRI,xi(1),yi(1));
+    [Ti,p] = tsearch_safe(xyMesh,TRI,xIntersect(1),yIntersect(1));
     if ~isnan(Ti) % inside a mesh face
         triSegment(:) = Ti;
         weightsIntersect(1,:) = p;
         nodesIntersect(1,:) = TRI(Ti,:);
         for i = 2:nIntersections
-            [~,p] = tsearch_safe(xyMesh,TRI(Ti,:),xi(1),yi(1));
+            [~,p] = tsearch_safe(xyMesh,TRI(Ti,:),xIntersect(i),yIntersect(i));
             weightsIntersect(i,:) = p;
             nodesIntersect(i,:) = TRI(Ti,:);
         end

src/tools_lgpl/matlab/quickplot/progsrc/private/md_print.m

@@ -422,12 +422,12 @@
 
 % Apply BlackAxesWhiteFig unless we're saving the figure meta data
 ih = get(fig,'inverthardcopy');
-set(fig,'inverthardcopy','off')
 colorChange = cell(0,3);
 switch printObj.Name
     case {'MATLAB fig file','QUICKPLOT session file'}
         % in this case we want to save the figure as is
     otherwise
+        set(fig,'inverthardcopy','off')
         if isfield(printObj,'BlackAxesWhiteFig') && printObj.BlackAxesWhiteFig
             % support for "inverthardcopy" was dropped in MATLAB 2025a
             colorChange = cell(100,3);

src/tools_lgpl/matlab/quickplot/progsrc/private/qp_time2str.m

@@ -59,8 +59,12 @@
         else
             datefmt = 'dd-MMM-yyyy G HH:mm:ss';
         end
-        Date = datetime(timeValue,'ConvertFrom','datenum');
-        timeString = char(Date,datefmt);
+        try
+            Date = datetime(timeValue,'ConvertFrom','datenum');
+            timeString = char(Date,datefmt);
+        catch % older than version 2014b
+            timeString = datestr(timeValue,0);
+        end
     case {3,4} % day h:m:s
         % 3: discrete, 4: continuous
         timeString=cat(2,repmat('day ',nTimes,1),num2str(floor(timeValue)), ...

src/tools_lgpl/matlab/quickplot/progsrc/private/tecplot.m

@@ -232,6 +232,25 @@
     end
 end
 
+function [int_values,file] = get_int_list(file,nValues)
+int_values = zeros(1,nValues);
+i = 0;
+if nValues == 0
+    readFromCurrentLineOnly = true;
+else
+    readFromCurrentLineOnly = false;
+end
+while i < nValues || readFromCurrentLineOnly
+    i = i+1;
+    try
+        [int_values(i),file] = get_int(file, readFromCurrentLineOnly);
+    catch err
+        if readFromCurrentLineOnly
+            break
+        end
+    end
+end
+
 function FI=open_ascii(FI,file)
 zone_found = false;
 in_record = 'HEADER';
@@ -511,9 +530,9 @@
                 nVar =  length(FI.Variables);
                 %
                 if strcmpi(Zone.Type,'ORDERED')
-                    if isfield(Zone,'kMax') % 3D
+                    if isfield(Zone,'KMax') % 3D
                         blockSize = [Zone.IMax Zone.JMax Zone.KMax];
-                    elseif isfield(Zone,'jMax') % 2D
+                    elseif isfield(Zone,'JMax') % 2D
                         blockSize = [Zone.IMax Zone.JMax];
                     else % 1D
                         blockSize = Zone.IMax;
@@ -543,7 +562,7 @@
                 FI.Zone(z).Data = data;
                 %
                 if ~strcmpi(Zone.Type,'ORDERED')
-                    if isfield(Zone,'elementSize') && ~isempty(Zone.ElementSize)
+                    if isfield(Zone,'ElementSize') && ~isempty(Zone.ElementSize)
                         blockSize = [Zone.ElementSize FI.Zone(z).NElements];
                         [topo,nRead] = fscanf(file.fid,'%i',prod(blockSize));
                         if nRead < prod(blockSize)
@@ -609,6 +628,7 @@
                 value = value * 10^exponent;
             end
             newData = cat(1,newData(1:end-1),repmat(value,newData(end),1));
+            nRead = length(newData);
 
         otherwise
             if nTotalRead+nRead < numValues

src/tools_lgpl/matlab/quickplot/progsrc/private/tecplotfil.m

@@ -162,13 +162,13 @@
 Out=cell2struct(DataProps,PropNames,2);
 
 if strcmpi(Zone.Type,'ORDERED')
-    if isfield(Zone,'iMax')
+    if isfield(Zone,'IMax')
         Out.DimFlag(M_) = 1;
     end
-    if isfield(Zone,'jMax')
+    if isfield(Zone,'JMax')
         Out.DimFlag(N_) = 1;
     end
-    if isfield(Zone,'kMax')
+    if isfield(Zone,'KMax')
         Out.DimFlag(K_) = 1;
     end
 else

src/tools_lgpl/matlab/quickplot/progsrc/qp_gridview.m

@@ -133,12 +133,19 @@
                 XY(j,2) = Y(MN(1),MN(2));
                 for i = 2:size(GRID.Selected.Range,1)
                     dMN = GRID.Selected.Range(i,:) - MN;
-                    sMN = sign(dMN);
-                    for d = 1:max(abs(dMN))
-                        MN = MN + sMN;
-                        j = j + 1;
-                        XY(j,1) = X(MN(1),MN(2));
-                        XY(j,2) = Y(MN(1),MN(2));
+                    % follow Bresenham-style stepping in case
+                    % abs(dMN(1)) ~= abs(dMN(2))
+                    % which should never be the case.
+                    nSteps = max(abs(dMN));
+                    if nSteps > 0
+                        steps = (1:nSteps)';
+                        pathMN = round(repmat(MN,nSteps,1) + steps*(dMN/nSteps));
+                        for d = 1:nSteps
+                            MN = pathMN(d,:);
+                            j = j + 1;
+                            XY(j,1) = X(MN(1),MN(2));
+                            XY(j,2) = Y(MN(1),MN(2));
+                        end
                     end
                 end
             case 'ugrid'