Skip to content

Commit 41409b9

Browse files
committed
chore: add capability check for servicemonitor
1 parent ece4c96 commit 41409b9

File tree

7 files changed

+7
-5
lines changed

7 files changed

+7
-5
lines changed

helm/charts/hydra/templates/service-admin.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ spec:
3232
selector:
3333
app.kubernetes.io/name: {{ include "hydra.name" . }}
3434
app.kubernetes.io/instance: {{ .Release.Name }}
35-
{{- if .Values.serviceMonitor.enabled }}
35+
{{- if and (.Values.serviceMonitor.enabled) (.Capabilities.APIVersions.Has "monitoring.coreos.com/v1") }}
3636
---
3737
apiVersion: monitoring.coreos.com/v1
3838
kind: ServiceMonitor

helm/charts/keto/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ Access Control Policies as a Server
7474
| fullnameOverride | string | `""` | |
7575
| image.pullPolicy | string | `"IfNotPresent"` | Default image pull policy |
7676
| image.repository | string | `"oryd/keto"` | Ory KETO image |
77-
| image.tag | string | `"v0.12.0"` | Ory KETO version |
77+
| image.tag | string | `"v0.14.0"` | Ory KETO version |
7878
| imagePullSecrets | list | `[]` | |
7979
| ingress.read.annotations | object | `{}` | |
8080
| ingress.read.className | string | `""` | |

helm/charts/kratos/templates/service-admin.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ spec:
3737
selector:
3838
app.kubernetes.io/name: {{ include "kratos.name" . }}
3939
app.kubernetes.io/instance: {{ .Release.Name }}
40-
{{- if .Values.serviceMonitor.enabled }}
40+
{{- if and (.Values.serviceMonitor.enabled) (.Capabilities.APIVersions.Has "monitoring.coreos.com/v1") }}
4141
---
4242
apiVersion: monitoring.coreos.com/v1
4343
kind: ServiceMonitor

helm/charts/kratos/templates/statefulset-svc.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ spec:
3535
selector:
3636
app.kubernetes.io/name: {{ include "kratos.fullname" . }}-courier
3737
app.kubernetes.io/instance: {{ .Release.Name }}
38-
{{- if .Values.serviceMonitor.enabled }}
38+
{{- if and (.Values.serviceMonitor.enabled) (.Capabilities.APIVersions.Has "monitoring.coreos.com/v1") }}
3939
---
4040
apiVersion: monitoring.coreos.com/v1
4141
kind: ServiceMonitor

helm/charts/oathkeeper/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,7 @@ A Helm chart for deploying ORY Oathkeeper in Kubernetes
137137
| service.proxy.name | string | `"http"` | The service port name. Useful to set a custom service port name if it must follow a scheme (e.g. Istio) |
138138
| service.proxy.port | int | `4455` | The service port |
139139
| service.proxy.type | string | `"ClusterIP"` | The service type |
140+
| serviceMonitor.enabled | bool | `false` | |
140141
| serviceMonitor.labels | object | `{}` | Provide additional labels to the ServiceMonitor resource metadata |
141142
| serviceMonitor.metricRelabelings | list | `[]` | Provide additional metricRelabelings to apply to samples before ingestion. |
142143
| serviceMonitor.relabelings | list | `[]` | Provide additional relabelings to apply to samples before scraping |

helm/charts/oathkeeper/templates/service-metrics.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ spec:
3232
selector:
3333
app.kubernetes.io/name: {{ include "oathkeeper.name" . }}
3434
app.kubernetes.io/instance: {{ .Release.Name }}
35-
{{- if .Capabilities.APIVersions.Has "monitoring.coreos.com/v1" }}
35+
{{- if and (.Values.serviceMonitor.enabled) (.Capabilities.APIVersions.Has "monitoring.coreos.com/v1") }}
3636
---
3737
apiVersion: monitoring.coreos.com/v1
3838
kind: ServiceMonitor

helm/charts/oathkeeper/values.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -395,6 +395,7 @@ pdb:
395395
## -- Parameters for the Prometheus ServiceMonitor objects.
396396
# Reference: https://docs.openshift.com/container-platform/4.6/rest_api/monitoring_apis/servicemonitor-monitoring-coreos-com-v1.html
397397
serviceMonitor:
398+
enabled: false
398399
# -- HTTP scheme to use for scraping.
399400
scheme: http
400401
# -- Interval at which metrics should be scraped

0 commit comments

Comments
 (0)