PR review of jsocol#142

Author: Vincent Genty

tests/adapters/flow_validation/helpers.py

@@ -3,6 +3,7 @@
 from typing import Union
 from uuid import UUID
 
+from tests import common
 from tests.fixtures.valid_flow_json import *  # noqa: F401, F403, pylint: disable=wildcard-import,unused-wildcard-import
 from use_case_executor.adapters.flow_validation.edge import Edge
 from use_case_executor.adapters.flow_validation.edge_data.direct_link_data import (
@@ -54,10 +55,6 @@
 from use_case_executor.domain.flow.node_data.node_type import NodeType
 
 
-def _string_to_uuid_or_none(value: Optional[str]) -> Optional[UUID]:
-    return UUID(value) if value is not None else None
-
-
 def check_answer_node(  # pylint: disable=too-many-locals
     node: Node,
     node_uuid: UUID,
@@ -186,7 +183,7 @@ def check_user_input_node(
     assert node.uuid == node_uuid
     user_input_data = node.data
     assert isinstance(user_input_data, UserInputData)
-    assert user_input_data.variable_uuid == _string_to_uuid_or_none(
+    assert user_input_data.variable_uuid == common.string_to_uuid_or_none(
         node_data_dict["variable_uuid"]
     )
     assert user_input_data.prompt_translations == node_data_dict["prompt_translations"]
@@ -207,7 +204,7 @@ def check_user_input_node(
         )
         assert (
             user_input_data.cancel_quick_reply_go_to_use_case_data.target_use_case_uuid
-            == _string_to_uuid_or_none(
+            == common.string_to_uuid_or_none(
                 go_to_use_case_data_dict.get("target_use_case_uuid")
             )
         )
@@ -222,7 +219,7 @@ def check_create_ticket_node(node: Node, node_uuid: UUID, node_data_dict: dict)
     assert isinstance(create_ticket_data, CreateTicketData)
 
     assert create_ticket_data.agent_channel_uuid == (
-        _string_to_uuid_or_none(node_data_dict.get("agent_channel_uuid"))
+        common.string_to_uuid_or_none(node_data_dict.get("agent_channel_uuid"))
     )
 
     for actual_system_field, system_field in zip(

tests/common.py

@@ -21,6 +21,10 @@
 test_session = orm.scoped_session(orm.sessionmaker())
 
 
+def string_to_uuid_or_none(value: Optional[str]) -> Optional[UUID]:
+    return UUID(value) if value is not None else None
+
+
 def assert_responses_call(
     call: Call,
     method: str,