ManualDispatchCallbackFix

Author: LuKeSt0rm

dll/dll/steam_client.h

@@ -110,12 +110,6 @@ public ISteamClient
 private:
     bool user_logged_in = false;
     bool server_init = false;
-
-    // SteamServersConnected_t must be fired on the user/client pipe shortly after login
-    // Without this: Games relying on this callback for matchmaking/server browser will get stuck
-    // in GetNextCallback forever waiting for a "connected" signal that never arrives
-    bool client_servers_connected_sent = false;
-    std::chrono::high_resolution_clock::time_point client_logon_time{};
 
     std::atomic_bool cb_run_active = false;
     std::atomic<unsigned long long> last_cb_run{};

dll/steam_client.cpp

@@ -33,27 +33,6 @@ void Steam_Client::background_thread_proc()
         network->Run(); // networking must run first since it receives messages used by each run_callback()
         run_every_runcb->run(); // call each run_callback()
 
-        // Fire SteamServersConnected_t and PersonaStateChange_t once after login
-        if (IsUserLogIn() && !client_servers_connected_sent) {
-            if (check_timedout(client_logon_time, 0.1)) {
-                client_servers_connected_sent = true;
-                settings_client->set_offline(false);
-
-                SteamServersConnected_t conn{};
-                PersonaStateChange_t persona{};
-                persona.m_ulSteamID = settings_client->get_local_steam_id().ConvertToUint64();
-                persona.m_nChangeFlags = k_EPersonaChangeName;
-
-                if (callback_results_client->isManualDispatch()) {
-                    callback_results_client->triggerCbAll(&conn, conn.k_iCallback, sizeof(conn));
-                    callback_results_client->triggerCbAll(&persona, persona.k_iCallback, sizeof(persona));
-                } else {
-                    callbacks_client->addCBResult(conn.k_iCallback, &conn, sizeof(conn));
-                    callbacks_client->addCBResult(persona.k_iCallback, &persona, sizeof(persona));
-                }
-            }
-        }
-
         // Flush call results into ManualDispatch queue; guard keeps CCallbackBase::Run() off this thread
         if (IsUserLogIn() && callback_results_client->isManualDispatch()) {
             callback_results_client->runCallResults();
@@ -291,8 +270,6 @@ void Steam_Client::userLogIn()
     callback_results_client->clear();
     network->addListenId(settings_client->get_local_steam_id());
     user_logged_in = true;
-    client_servers_connected_sent = false;
-    client_logon_time = std::chrono::high_resolution_clock::now();
 }
 
 void Steam_Client::serverInit()
@@ -1042,27 +1019,6 @@ void Steam_Client::RunCallbacks(bool runClientCB, bool runGameserverCB)
     // PRINT_DEBUG("run_every_runcb *********");
     run_every_runcb->run();
 
-    // Fire SteamServersConnected_t and PersonaStateChange_t once after login
-    if (runClientCB && IsUserLogIn() && !client_servers_connected_sent) {
-        if (check_timedout(client_logon_time, 0.1)) {
-            client_servers_connected_sent = true;
-            settings_client->set_offline(false);
-
-            SteamServersConnected_t conn{};
-            PersonaStateChange_t persona{};
-            persona.m_ulSteamID = settings_client->get_local_steam_id().ConvertToUint64();
-            persona.m_nChangeFlags = k_EPersonaChangeName;
-
-            if (callback_results_client->isManualDispatch()) {
-                callback_results_client->triggerCbAll(&conn, conn.k_iCallback, sizeof(conn));
-                callback_results_client->triggerCbAll(&persona, persona.k_iCallback, sizeof(persona));
-            } else {
-                callbacks_client->addCBResult(conn.k_iCallback, &conn, sizeof(conn));
-                callbacks_client->addCBResult(persona.k_iCallback, &persona, sizeof(persona));
-            }
-        }
-    }
-
     // PRINT_DEBUG("steam_gameserver *********");
     steam_gameserver->RunCallbacks();