fix: add more unit tests

Author: dnitsch

Makefile

@@ -1,8 +1,8 @@
 
 OWNER := dnitsch
 NAME := configmanager
-GIT_TAG := "1.0.1"
-VERSION := "v1.0.1"
+GIT_TAG := "1.1.0"
+VERSION := "v1.1.0"
 # VERSION := "$(shell git describe --tags --abbrev=0)"
 REVISION := $(shell git rev-parse --short HEAD)
 

pkg/generator/generator.go

@@ -262,6 +262,7 @@ func (c *GenVars) stripPrefix(in, prefix string) string {
 	return stripPrefix(in, prefix, c.config.tokenSeparator, c.config.keySeparator)
 }
 
+// stripPrefix 
 func stripPrefix(in, prefix, tokenSeparator, keySeparator string) string {
 	t := in
 	b := regexp.MustCompile(`[|].*`).ReplaceAll([]byte(t), []byte(""))

pkg/generator/generator_test.go

@@ -62,6 +62,38 @@ func TestStripPrefixNormal(t *testing.T) {
 	}
 }
 
+func Test_stripPrefix(t *testing.T) {
+	f := newFixture(t)
+	f.goodGenVars(standardop, standardts)
+	tests := []struct {
+		name   string
+		token  string
+		prefix string
+		expect string
+	}{
+		{
+			name:   "simple",
+			token:  fmt.Sprintf("%s#/test/123", SecretMgrPrefix),
+			prefix: SecretMgrPrefix,
+			expect: "/test/123",
+		},
+		{
+			name:   "key appended",
+			token:  fmt.Sprintf("%s#/test/123|key", ParamStorePrefix),
+			prefix: ParamStorePrefix,
+			expect: "/test/123",
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got := f.c.stripPrefix(tt.token, tt.prefix)
+			if tt.expect != got {
+				t.Errorf(testutils.TestPhrase, tt.expect, got)
+			}
+		})
+	}
+}
+
 func Test_NormaliseMap(t *testing.T) {
 	f := newFixture(t)
 	f.goodGenVars(standardop, standardts)

pkg/generator/paramstore_test.go

@@ -59,6 +59,40 @@ func Test_GetParamStoreVarHappy(t *testing.T) {
 			},
 			genVars: &GenVars{},
 		},
+		{
+			name:  "successVal with keyseparator",
+			token: "AWSPARAMSTR#/token/1|somekey",
+			value: tsuccessParam,
+			mockClient: func(t *testing.T) paramStoreApi {
+				return mockParamApi(func(ctx context.Context, params *ssm.GetParameterInput, optFns ...func(*ssm.Options)) (*ssm.GetParameterOutput, error) {
+					t.Helper()
+					if params.Name == nil {
+						t.Fatal("expect name to not be nil")
+					}
+
+					if strings.Contains(*params.Name, "#") {
+						t.Errorf("incorrectly stripped token separator")
+					}
+
+					if strings.Contains(*params.Name, "|somekey") {
+						t.Errorf("incorrectly stripped key separator")
+					}
+
+					if strings.Contains(*params.Name, ParamStorePrefix) {
+						t.Errorf("incorrectly stripped prefix")
+					}
+
+					if !params.WithDecryption {
+						t.Fatal("expect WithDecryption to not be false")
+					}
+
+					return &ssm.GetParameterOutput{
+						Parameter: &types.Parameter{Value: &tsuccessParam},
+					}, nil
+				})
+			},
+			genVars: &GenVars{},
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {