Skip to content

Commit 156f6b6

Browse files
committed
fix(docs): put badges in a row
add coverage to main branch in Sonar
1 parent 5ba544d commit 156f6b6

File tree

3 files changed

+6
-11
lines changed

3 files changed

+6
-11
lines changed

.github/workflows/build.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,4 +68,3 @@ jobs:
6868
-Dsonar.projectVersion=${{ needs.set-deps-dotnet-poop-here.outputs.semVer }}
6969
-Dsonar.go.coverage.reportPaths=/github/workspace/.coverage/out
7070
-Dsonar.go.tests.reportPaths=/github/workspace/.coverage/report-junit.xml
71-
-X

.github/workflows/pr.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,7 @@ jobs:
5656
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information
5757
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} # Generate a token on Sonarcloud.io, add it to the secrets of this repo with the name SONAR_TOKEN (Settings > Secrets > Actions > add new repository secret)
5858
with:
59-
# Additional arguments for the sonarcloud scanner
6059
args:
61-
# Unique keys of your project and organization. You can find them in SonarCloud > Information (bottom-left menu)
62-
# mandatory
63-
-Dsonar.projectVersion=$SEMVER
60+
-Dsonar.projectVersion=${{ needs.set-deps-dotnet-poop-here.outputs.semVer }}
6461
-Dsonar.go.coverage.reportPaths=/github/workspace/.coverage/out
62+
-Dsonar.go.tests.reportPaths=/github/workspace/.coverage/report-junit.xml

README.md

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,10 @@
11
# Config Manager
22

33
[![Go Report Card](https://goreportcard.com/badge/github.com/dnitsch/configmanager)](https://goreportcard.com/report/github.com/dnitsch/configmanager)
4-
54
[![Bugs](https://sonarcloud.io/api/project_badges/measure?project=dnitsch_configmanager&metric=bugs)](https://sonarcloud.io/summary/new_code?id=dnitsch_configmanager)
6-
75
[![Technical Debt](https://sonarcloud.io/api/project_badges/measure?project=dnitsch_configmanager&metric=sqale_index)](https://sonarcloud.io/summary/new_code?id=dnitsch_configmanager)
8-
96
[![Reliability Rating](https://sonarcloud.io/api/project_badges/measure?project=dnitsch_configmanager&metric=reliability_rating)](https://sonarcloud.io/summary/new_code?id=dnitsch_configmanager)
10-
117
[![Vulnerabilities](https://sonarcloud.io/api/project_badges/measure?project=dnitsch_configmanager&metric=vulnerabilities)](https://sonarcloud.io/summary/new_code?id=dnitsch_configmanager)
12-
138
[![Coverage](https://sonarcloud.io/api/project_badges/measure?project=dnitsch_configmanager&metric=coverage)](https://sonarcloud.io/summary/new_code?id=dnitsch_configmanager)
149

1510
Package used for retrieving application settings from various sources.
@@ -154,7 +149,10 @@ For Azure KeyVault the first part of the token needs to be the name of the vault
154149
For HashicorpVault the first part of the token needs to be the name of the mountpath. In Dev Vaults this is `"secret"`,
155150
e.g.:
156151

157-
`VAULT://secret/demo/configmanager|test`
152+
`VAULT://secret___demo/configmanager|test`
153+
154+
The hardcoded separator cannot be modified and you must separate your `mountPath` with `___` (3x `_`) followed by the key to the secret.
155+
158156

159157
The Hashicorp Vault functions in the same exact way as the other implementations. It will retrieve the JSON object and can be looked up within it by using a key separator.
160158

0 commit comments

Comments
 (0)